Remove management command and fix test failures

- Remove refresh_flight_totals management command (won't be used)
- Update task documentation to run every 5-10 minutes
- Fix all test failures by adding refresh_denormalized_totals() calls
  after incr() operations that check total_views/total_clicks
- Update tests that manually set total_clicks/total_views to use
  save(update_fields=[...]) to avoid triggering other updates

Author: ericholscher

adserver/management/commands/refresh_flight_totals.py

@@ -929,8 +929,8 @@ def refresh_flight_denormalized_totals():
     """
     Refresh denormalized total_views and total_clicks fields for all live flights.
 
-    This task should be run periodically (e.g., hourly) to update the denormalized
-    fields without causing lock contention on the Flight table.
+    This task should be run periodically (e.g., every 5-10 minutes) to update
+    the denormalized fields without causing lock contention on the Flight table.
     """
     log.info("Refreshing denormalized totals for live flights")
 

adserver/tasks.py

@@ -271,13 +271,13 @@ def test_custom_interval(self):
             self.assertTrue(self.backend.filter_flight(self.cpm_flight))
 
             self.cpm_flight.total_views = 10_000 - pace - 1
-            self.cpm_flight.save()
+            self.cpm_flight.save(update_fields=['total_views'])
             self.assertEqual(self.cpm_flight.views_needed_this_interval(), 1)
             self.assertTrue(self.backend.filter_flight(self.cpm_flight))
 
             # Don't show this flight anymore. It is above pace
             self.cpm_flight.total_views = 10_000 - pace
-            self.cpm_flight.save()
+            self.cpm_flight.save(update_fields=['total_views'])
             self.assertEqual(self.cpm_flight.views_needed_this_interval(), 0)
             self.assertFalse(self.backend.filter_flight(self.cpm_flight))
 
@@ -466,8 +466,8 @@ def test_clicks_needed(self):
         for _ in range(clicks_to_simulate):
             self.advertisement1.incr(CLICKS, self.publisher)
 
-        # Refresh the data on the include_flight - gets the denormalized views
-        self.include_flight.refresh_from_db()
+        # Refresh the denormalized totals manually since they're no longer updated in real-time
+        self.include_flight.refresh_denormalized_totals()
 
         self.assertEqual(self.include_flight.clicks_needed_this_interval(), 23)
 
@@ -491,8 +491,8 @@ def test_views_needed(self):
         for _ in range(views_to_simulate):
             self.advertisement1.incr(VIEWS, self.publisher)
 
-        # Refresh the data on the include_flight - gets the denormalized views
-        self.cpm_flight.refresh_from_db()
+        # Refresh the denormalized totals manually since they're no longer updated in real-time
+        self.cpm_flight.refresh_denormalized_totals()
 
         self.assertEqual(self.cpm_flight.views_needed_this_interval(), 313)
 

adserver/tests/test_decision_engine.py

@@ -522,6 +522,8 @@ def test_campaign_totals(self):
         self.ad1.incr(CLICKS, self.publisher)
         self.ad1.incr(CLICKS, self.publisher)
 
+        self.flight.refresh_denormalized_totals()
+
         self.assertAlmostEqual(self.campaign.total_value(), 4.0)
 
         cpm_flight = get(
@@ -551,6 +553,10 @@ def test_campaign_totals(self):
         ad2.incr(VIEWS, self.publisher)
         ad2.incr(VIEWS, self.publisher)
 
+        # Refresh denormalized totals for both flights
+        self.flight.refresh_denormalized_totals()
+        cpm_flight.refresh_denormalized_totals()
+
         self.assertAlmostEqual(self.campaign.total_value(), 4.3)
 
     def test_flight_state(self):
@@ -576,12 +582,12 @@ def test_flight_value_remaining(self):
         self.flight.save()
         self.assertAlmostEqual(self.flight.value_remaining(), 100 * 2)
 
-        # Each click is worth $2
+        # Each click is $2
         self.ad1.incr(CLICKS, self.publisher)
         self.ad1.incr(CLICKS, self.publisher)
         self.ad1.incr(CLICKS, self.publisher)
 
-        self.flight.refresh_from_db()
+        self.flight.refresh_denormalized_totals()
         self.assertAlmostEqual(self.flight.value_remaining(), 97 * 2)
 
         self.flight.cpm = 50.0
@@ -596,7 +602,7 @@ def test_flight_value_remaining(self):
         for _ in range(25):
             self.ad1.incr(VIEWS, self.publisher)
 
-        self.flight.refresh_from_db()
+        self.flight.refresh_denormalized_totals()
         self.assertAlmostEqual(self.flight.value_remaining(), 5.0 - (25 * 0.05))
 
     def test_projected_total_value(self):
@@ -607,7 +613,7 @@ def test_projected_total_value(self):
         self.ad1.incr(CLICKS, self.publisher)
         self.ad1.incr(CLICKS, self.publisher)
 
-        self.flight.refresh_from_db()
+        self.flight.refresh_denormalized_totals()
         self.assertAlmostEqual(self.flight.projected_total_value(), 1000 * 2)
 
         self.flight.cpm = 50.0
@@ -727,7 +733,7 @@ def test_refund(self):
         for click in (click1, click2, click3):
             self.assertIsNotNone(click)
 
-        self.flight.refresh_from_db()
+        self.flight.refresh_denormalized_totals()
 
         self.assertEqual(self.flight.total_clicks, 3)
 
@@ -760,7 +766,7 @@ def test_refund(self):
             self.assertTrue(offer.clicked)
 
         # Reload data from the DB
-        self.flight.refresh_from_db()
+        self.flight.refresh_denormalized_totals()
         impression.refresh_from_db()
 
         self.assertEqual(self.flight.total_clicks, 1)