-
Notifications
You must be signed in to change notification settings - Fork 67
getScrollAccessor on window seems wrong #131
Copy link
Copy link
Open
Labels
Description
dom-helpers/src/getScrollAccessor.ts
Line 19 in 536ae60
| win.scrollTo(win[offset], val) |
When offset is pageYOffset, scrollTo will be invoked with scrollTo(currentPageYOffset, newPageYOffset). When offset is pageXOffset, scrollTo will be invoked with scrollTo(currentPageXOffset, newPageXOffset).
This doesn't seem to be right. What we want to do is to preserve the value of X when we are changing Y and vice-versa.
Reactions are currently unavailable