Fix tests errors

Author: AgustinGil21

internal/api/apilibs/response.go

@@ -12,7 +12,7 @@ type Response[T any] struct {
 	Success      bool          `json:"success"`
 	Payload      T             `json:"payload,omitempty"`
 	Error        *errors.Error `json:"error,omitempty"`
-	Warnings     []error       `json:"warnings,omitempty"`
+	Warnings     []string      `json:"warnings,omitempty"`
 	Timestamp    time.Time     `json:"timestamp"`
 	ResponseTime string        `json:"responseTime"`
 }
@@ -34,6 +34,14 @@ func getRequestStartTime(c *gin.Context) (time.Time, bool) {
 	return start, ok
 }
 
+func errorsToStrings(errs []error) []string {
+	out := make([]string, 0, len(errs))
+	for _, e := range errs {
+		out = append(out, e.Error())
+	}
+	return out
+}
+
 func ToResponse[T any](c *gin.Context, in ResponseInput[T]) {
 	var statusCode int
 	startTime, _ := getRequestStartTime(c)
@@ -55,7 +63,7 @@ func ToResponse[T any](c *gin.Context, in ResponseInput[T]) {
 		Success:      success,
 		Payload:      in.Payload,
 		Error:        in.Error,
-		Warnings:     in.Warnings,
+		Warnings:     errorsToStrings(in.Warnings),
 		Timestamp:    time.Now().UTC(),
 		ResponseTime: time.Since(startTime).String(),
 	})

internal/api/apilibs/response_test.go

@@ -2,6 +2,7 @@ package apilibs
 
 import (
 	"encoding/json"
+	"net/http"
 	"net/http/httptest"
 	"testing"
 	"time"
@@ -279,7 +280,6 @@ func TestResponseTimestampAndResponseTime(t *testing.T) {
 func TestToResponse_WithoutRequestStartTime(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, _ := gin.CreateTestContext(w)
-	// No request_start_time set
 
 	ToResponse(c, ResponseInput[string]{
 		StatusSuccess: 200,
@@ -294,8 +294,8 @@ func TestToResponse_WithoutRequestStartTime(t *testing.T) {
 		t.Fatalf("unmarshal failed: %v", err)
 	}
 
-	if got.Success {
-		t.Fatal("expected Success false when no request_start_time")
+	if !got.Success {
+		t.Fatal("expected Success true even without request_start_time")
 	}
 }
 
@@ -360,6 +360,14 @@ func TestToResponse_StatusCodeVariations(t *testing.T) {
 				t.Fatalf("expected status %d, got %d", tc.expectedStatusCode, w.Code)
 			}
 
+			// 204 has no body by HTTP spec
+			if tc.expectedStatusCode == http.StatusNoContent {
+				if w.Body.Len() != 0 {
+					t.Fatal("expected empty body for 204 No Content")
+				}
+				return
+			}
+
 			var got Response[string]
 			if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
 				t.Fatalf("unmarshal failed: %v", err)
@@ -369,5 +377,6 @@ func TestToResponse_StatusCodeVariations(t *testing.T) {
 				t.Fatalf("expected Success %v, got %v", tc.expectedSuccess, got.Success)
 			}
 		})
+
 	}
 }