Refactor test files to improve readability and maintainability: Remove unnecessary blank lines in various test files across the project, enhancing code clarity and consistency. This change contributes to better organization and easier navigation of the test suite.

Author: char2cs

cmd/quiver/assets/icon_utils_test.go

@@ -105,50 +105,50 @@ func TestEmbeddedIcons(t *testing.T) {
 
 func TestIconManager_GetIconPath(t *testing.T) {
 	manager := NewIconManager()
-	
+
 	// Initially should be empty
 	if manager.GetIconPath() != "" {
 		t.Error("Icon path should be empty initially")
 	}
-	
+
 	// Save icon to temp and check path
 	tempFile, err := manager.SaveIconToTemp()
 	if err != nil {
 		t.Fatalf("Failed to save icon to temp: %v", err)
 	}
 	defer manager.Cleanup()
-	
+
 	if manager.GetIconPath() != tempFile {
 		t.Error("Icon path should match saved temp file")
 	}
 }
 
 func TestIconManager_Cleanup(t *testing.T) {
 	manager := NewIconManager()
-	
+
 	// Test cleanup when no icon is saved
 	err := manager.Cleanup()
 	if err != nil {
 		t.Errorf("Cleanup should not error when no icon is saved: %v", err)
 	}
-	
+
 	// Save icon and test cleanup
 	tempFile, err := manager.SaveIconToTemp()
 	if err != nil {
 		t.Fatalf("Failed to save icon to temp: %v", err)
 	}
-	
+
 	// Verify file exists
 	if _, err := os.Stat(tempFile); os.IsNotExist(err) {
 		t.Error("Icon file should exist before cleanup")
 	}
-	
+
 	// Cleanup and verify file is removed
 	err = manager.Cleanup()
 	if err != nil {
 		t.Errorf("Cleanup should not error: %v", err)
 	}
-	
+
 	// Verify file is removed
 	if _, err := os.Stat(tempFile); !os.IsNotExist(err) {
 		t.Error("Icon file should be removed after cleanup")
@@ -157,19 +157,19 @@ func TestIconManager_Cleanup(t *testing.T) {
 
 func TestIconManager_PlatformSpecific(t *testing.T) {
 	manager := NewIconManager()
-	
+
 	// Test GetIconForPlatform for all platforms
 	iconData := manager.GetIconForPlatform()
 	if len(iconData) == 0 {
 		t.Error("Icon data should not be empty for any platform")
 	}
-	
+
 	// Test GetIconSize for all platforms
 	sizeData := manager.GetIconSize()
 	if len(sizeData) == 0 {
 		t.Error("Icon size data should not be empty for any platform")
 	}
-	
+
 	// Test platform-specific behavior
 	switch runtime.GOOS {
 	case "windows":
@@ -212,25 +212,25 @@ func TestIconManager_PlatformSpecific(t *testing.T) {
 
 func TestIconManager_MultipleOperations(t *testing.T) {
 	manager := NewIconManager()
-	
+
 	// Test multiple save operations
 	tempFile1, err := manager.SaveIconToTemp()
 	if err != nil {
 		t.Fatalf("First save failed: %v", err)
 	}
 	defer manager.Cleanup()
-	
+
 	// Save again (should overwrite)
 	tempFile2, err := manager.SaveIconToTemp()
 	if err != nil {
 		t.Fatalf("Second save failed: %v", err)
 	}
-	
+
 	// Paths should be the same
 	if tempFile1 != tempFile2 {
 		t.Error("Icon path should remain the same on multiple saves")
 	}
-	
+
 	// Test that file exists and has content
 	if _, err := os.Stat(tempFile2); os.IsNotExist(err) {
 		t.Error("Icon file should exist after second save")

cmd/quiver/ui/model_test.go

@@ -695,9 +695,9 @@ func TestModel_ShowQueryError_Comprehensive(t *testing.T) {
 
 	// Test different query error scenarios
 	testCases := []struct {
-		query    string
-		status   int
-		error    string
+		query  string
+		status int
+		error  string
 	}{
 		{"test query", 404, "not found"},
 		{"error query", 500, "internal server error"},
@@ -838,7 +838,7 @@ func TestModel_SetStatus_Comprehensive(t *testing.T) {
 
 	// Test different status scenarios
 	statuses := []struct {
-		message string
+		message  string
 		duration time.Duration
 	}{
 		{"Normal status", 2 * time.Second},

cmd/quiver/ui/service_test.go

@@ -178,7 +178,7 @@ func TestRunUIModelState(t *testing.T) {
 func TestRunUIComprehensive(t *testing.T) {
 	// Test comprehensive RunUI functionality
 	w := watcher.NewWatcherService()
-	
+
 	// Test that we can create a model (what RunUI does)
 	model := NewModel(w)
 	if model == nil {
@@ -242,7 +242,7 @@ func TestRunUIWithDifferentWatcherStates(t *testing.T) {
 
 func TestRunUIErrorScenarios(t *testing.T) {
 	// Test various error scenarios that RunUI might handle
-	
+
 	// Test with nil watcher
 	defer func() {
 		if r := recover(); r != nil {
@@ -273,7 +273,7 @@ func TestRunUIModelLifecycle(t *testing.T) {
 
 	// Test that model can handle updates (what RunUI does)
 	msg := tea.WindowSizeMsg{Width: 100, Height: 50}
-	updatedModel, cmd := model.Update(msg)
+	updatedModel, _ := model.Update(msg)
 	if updatedModel == nil {
 		t.Error("Update should return a model")
 	}
@@ -287,7 +287,7 @@ func TestRunUIModelLifecycle(t *testing.T) {
 	// Test cleanup (what RunUI does on exit)
 	if model.cancel != nil {
 		model.cancel()
-		
+
 		// Verify context is cancelled
 		select {
 		case <-model.ctx.Done():

internal/api/api_test.go

@@ -14,13 +14,13 @@ import (
 func TestAPI_Run(t *testing.T) {
 	// Create a mock watcher
 	watcherService := watcher.NewWatcherService()
-	
+
 	// Create mock usecases
 	mockUsecases := &usecases.Usecases{}
-	
+
 	// Create API instance
 	api := NewAPI(watcherService, mockUsecases)
-	
+
 	// Test that Run method doesn't panic
 	// Note: This will actually start a server, so we test it in a goroutine
 	// and then we can't easily test the full functionality without mocking
@@ -30,7 +30,7 @@ func TestAPI_Run(t *testing.T) {
 			t.Errorf("API.Run() panicked: %v", r)
 		}
 	}()
-	
+
 	// The Run method will block, so we can't test it fully without mocking
 	// But we can test that the method exists and the API struct is properly initialized
 	if api.router == nil {
@@ -47,40 +47,40 @@ func TestAPI_Run(t *testing.T) {
 func TestAPI_SetupMiddleware(t *testing.T) {
 	// Create a mock watcher
 	watcherService := watcher.NewWatcherService()
-	
+
 	// Create mock usecases
 	mockUsecases := &usecases.Usecases{}
-	
+
 	// Create API instance
 	api := NewAPI(watcherService, mockUsecases)
-	
+
 	// Test that SetupMiddleware doesn't panic
 	defer func() {
 		if r := recover(); r != nil {
 			t.Errorf("API.SetupMiddleware() panicked: %v", r)
 		}
 	}()
-	
+
 	api.SetupMiddleware()
 }
 
 func TestAPI_SetupRoutes(t *testing.T) {
 	// Create a mock watcher
 	watcherService := watcher.NewWatcherService()
-	
+
 	// Create mock usecases
 	mockUsecases := &usecases.Usecases{}
-	
+
 	// Create API instance
 	api := NewAPI(watcherService, mockUsecases)
-	
+
 	// Test that SetupRoutes doesn't panic
 	defer func() {
 		if r := recover(); r != nil {
 			t.Errorf("API.SetupRoutes() panicked: %v", r)
 		}
 	}()
-	
+
 	api.SetupRoutes()
 }
 
@@ -127,15 +127,15 @@ func TestAPI_Run_ActualExecution(t *testing.T) {
 	// Test that Run method can be called without panicking
 	// We'll run it in a goroutine and then stop it quickly
 	done := make(chan bool)
-	
+
 	go func() {
 		defer func() {
 			if r := recover(); r != nil {
 				t.Errorf("API.Run() panicked: %v", r)
 			}
 			done <- true
 		}()
-		
+
 		// This will block, but we'll stop it quickly
 		api.Run()
 	}()
@@ -223,9 +223,8 @@ func TestAPI_NewAPI_WithDifferentWatcherConfigs(t *testing.T) {
 
 	// Test that we can get the watcher level
 	level := watcherService.GetLevel()
-	if level < 0 {
-		t.Error("Expected watcher level to be valid")
-	}
+	// level is a uint32, so it can't be negative, but we can test it's accessible
+	_ = level
 }
 
 func TestAPI_NewAPI_WithDifferentUsecases(t *testing.T) {
@@ -292,17 +291,17 @@ func TestAPI_NewAPI_WithDifferentWatcherLevels(t *testing.T) {
 
 	// Test with different levels to trigger different branches
 	levels := []int{0, 1, 2, 3, 4, 5, 6, 7, 8}
-	
+
 	for _, level := range levels {
 		// Set the watcher level (if possible)
 		watcherService.SetLevel(logrus.Level(level))
-		
+
 		// Create API with this level
 		api := NewAPI(watcherService, mockUsecases)
 		if api == nil {
 			t.Fatalf("Expected API to be created with level %d", level)
 		}
-		
+
 		// Test that the API is properly initialized
 		if api.router == nil {
 			t.Errorf("Expected router to be initialized with level %d", level)
@@ -324,7 +323,7 @@ func TestAPI_NewAPI_ComprehensiveBranches(t *testing.T) {
 	// Test that we can get the watcher level and config
 	level := watcherService.GetLevel()
 	config := watcherService.GetConfig()
-	
+
 	// Test different level scenarios
 	if level <= 4 {
 		// This should trigger debug mode
@@ -333,10 +332,10 @@ func TestAPI_NewAPI_ComprehensiveBranches(t *testing.T) {
 		// This should trigger release mode
 		_ = level
 	}
-	
+
 	// Test that config is accessible
 	_ = config
-	
+
 	// Test that the API is properly initialized
 	if api.router == nil {
 		t.Error("Expected router to be initialized")
@@ -383,4 +382,4 @@ func TestAPI_SetupRoutes_Comprehensive(t *testing.T) {
 	if api.router == nil {
 		t.Error("Expected router to be initialized")
 	}
-}
+}

internal/api/v1/controllers/arrows/routes_test.go

@@ -11,20 +11,20 @@ func TestSetupRoutes(t *testing.T) {
 	// Create a test router
 	router := gin.New()
 	routerGroup := router.Group("/api/v1")
-	
+
 	// Create a mock usecase
 	usecases := &usecase.ArrowsUsecase{}
-	
+
 	// Test that SetupRoutes doesn't panic
 	defer func() {
 		if r := recover(); r != nil {
 			t.Errorf("SetupRoutes() panicked: %v", r)
 		}
 	}()
-	
+
 	// Call SetupRoutes
 	SetupRoutes(routerGroup, usecases)
-	
+
 	// The function is currently empty, so we just test it doesn't panic
 	// and can be called with valid parameters
 }
@@ -33,14 +33,14 @@ func TestSetupRoutesWithNilUsecase(t *testing.T) {
 	// Create a test router
 	router := gin.New()
 	routerGroup := router.Group("/api/v1")
-	
+
 	// Test with nil usecase
 	defer func() {
 		if r := recover(); r != nil {
 			t.Errorf("SetupRoutes() panicked with nil usecase: %v", r)
 		}
 	}()
-	
+
 	SetupRoutes(routerGroup, nil)
 }
 
@@ -51,7 +51,7 @@ func TestSetupRoutesWithNilRouter(t *testing.T) {
 			t.Errorf("SetupRoutes() panicked with nil router: %v", r)
 		}
 	}()
-	
+
 	usecases := &usecase.ArrowsUsecase{}
 	SetupRoutes(nil, usecases)
 }
@@ -95,7 +95,7 @@ func TestSetupRoutes_EdgeCases(t *testing.T) {
 	// Test with different router groups
 	group1 := router.Group("/test1")
 	group2 := router.Group("/test2")
-	
+
 	SetupRoutes(group1, usecases)
 	SetupRoutes(group2, usecases)
 
@@ -106,4 +106,4 @@ func TestSetupRoutes_EdgeCases(t *testing.T) {
 	if group2 == nil {
 		t.Error("Expected group2 to be valid")
 	}
-}
+}