Force redirect when input categories do not match stored categories in hot questions

Author: pupi1985

qa-include/pages/hot.php

@@ -30,45 +30,51 @@
 
 // Get list of hottest questions, allow per-category if QA_ALLOW_UNINDEXED_QUERIES set in qa-config.php
 
-$categoryslugs = QA_ALLOW_UNINDEXED_QUERIES ? qa_request_parts(1) : null;
-$countslugs = $categoryslugs === null ? null : count($categoryslugs);
+$categoryslugs = qa_request_parts(1);
+$hasSlugs = !empty($categoryslugs);
+if (!QA_ALLOW_UNINDEXED_QUERIES && $hasSlugs) {
+	qa_redirect('hot');
+}
 
 $start = qa_get_start();
 $userid = qa_get_logged_in_userid();
 
 list($questions, $categories, $categoryid) = qa_db_select_with_pending(
 	qa_db_qs_selectspec($userid, 'hotness', $start, $categoryslugs, null, false, false, qa_opt_if_loaded('page_size_hot_qs')),
 	qa_db_category_nav_selectspec($categoryslugs, false, false, true),
-	$countslugs ? qa_db_slugs_to_category_id_selectspec($categoryslugs) : null
+	$hasSlugs ? qa_db_slugs_to_category_id_selectspec($categoryslugs) : null
 );
 
-if ($countslugs) {
+if ($hasSlugs) {
 	if (!isset($categoryid))
 		return include QA_INCLUDE_DIR . 'qa-page-not-found.php';
 
 	$categorytitlehtml = qa_html($categories[$categoryid]['title']);
 	$sometitle = qa_lang_html_sub('main/hot_qs_in_x', $categorytitlehtml);
 	$nonetitle = qa_lang_html_sub('main/no_questions_in_x', $categorytitlehtml);
-
 } else {
 	$sometitle = qa_lang_html('main/hot_qs_title');
 	$nonetitle = qa_lang_html('main/no_questions_found');
 }
 
+if (isset($categoryid) && $categories[$categoryid]['backpath'] !== qa_db_slugs_to_backpath($categoryslugs)) {
+	$expectedPathInUrl = implode('/', array_reverse(explode('/', $categories[$categoryid]['backpath'])));
+	qa_redirect('hot/' . $expectedPathInUrl);
+}
 
 // Prepare and return content for theme
 
 return qa_q_list_page_content(
 	$questions, // questions
 	qa_opt('page_size_hot_qs'), // questions per page
 	$start, // start offset
-	$countslugs ? $categories[$categoryid]['qcount'] : qa_opt('cache_qcount'), // total count
+	$hasSlugs ? $categories[$categoryid]['qcount'] : qa_opt('cache_qcount'), // total count
 	$sometitle, // title if some questions
 	$nonetitle, // title if no questions
-	QA_ALLOW_UNINDEXED_QUERIES ? $categories : array(), // categories for navigation
+	$categories, // categories for navigation
 	$categoryid, // selected category id
 	true, // show question counts in category navigation
-	QA_ALLOW_UNINDEXED_QUERIES ? 'hot/' : null, // prefix for links in category navigation (null if no navigation)
+	QA_ALLOW_UNINDEXED_QUERIES ? 'hot/' : null, // prefix for links in category navigation
 	qa_opt('feed_for_hot') ? 'hot' : null, // prefix for RSS feed paths (null to hide)
 	qa_html_suggest_ask() // suggest what to do next
 );