Refactor pyreverse Association Logic (#10397)

* Correct the test output to follow UML semantics

* Introduce composition

* Update all the printers to emit the right arrow types

* Update docstring

* Remove type annotations from test output

* Avoid processing duplicate relationships

* Update expected files again -> defaults to association

* change arrowhead for dot language for association relationsships

* Update comment

* Update comments in test file

* rename test folders for better clarity

* Enhance composition and aggregation handling in AST node processing so that the differentation between aggregation and composition is correct according to UMLEnhance composition and aggregation handling in AST node processing so that the differentation between aggregation and composition is correct according to UML

* Update relationship extraction to avoid duplicate entries

* Correctly infer the node type for Composition

* Update the functional test for comprehensions aswell

* Instead of checking not call node check for name node ==> more explicit

* Remove redundant checks in AggregationHandler

* Add todo note because infering type in Aggregation comprehensions is unreliable for now

* Enhance type resolution in AssociationsHandler and add utility functions for extracting element types and resolving class definitionsEnhance type resolution in AssociationsHandler and add utility functions for extracting element types and resolving class definitions

* Fix order so that tests pass

* Update the functional test files for attribute annotation, because now pyreverse correctly extracts Dummy as Association

* Use the new utility function for the other handlers aswell

* Fix regression that did not correctly detect Composition in fields.py

* Revert functional test for comprehension ==> this now works with new util functions

* Add correct arrow type for dot printer

* Update functional tests to include all file formats

* Fix diadefs tests (DoNothing now is correctly detected as Composition instead of assoiciation)

* Remove TODO since this now works

* Rename functional test files to relationships for better clarity

* rename to compositionshandler for better clarity

* Rename association-related classes to relationship aswell for improved clarity

* Try to fix the failing tests by processing instance attributes and class level attributes separate

* Fix diadefs_test again (cls_member is now also correctly identified as composition instead of association)

* Also consider composition when when filtering for --no-standalone ==> fixes last failing test

* Add newsfragment

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add functional tests

* Update newsfragement

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Andreas Finkler <[email protected]>

* Update fields test files

* Update comprehensions test file

* Reverse arrows in attribute annotation test files aswell

* Reverse arrows in writer

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Andreas Finkler <[email protected]>

Author: 3 people

doc/whatsnew/fragments/9045.feature

@@ -0,0 +1,4 @@
+Enhanced pyreverse to properly distinguish between UML relationship types (association, aggregation, composition) based on object ownership semantics. Type annotations without assignment are now treated as associations, parameter assignments as aggregations, and object instantiation as compositions.
+
+Closes #9045
+Closes #9267

pylint/pyreverse/diagrams.py

@@ -226,6 +226,7 @@ def extract_relationships(self) -> None:
             obj.attrs = self.get_attrs(node)
             obj.methods = self.get_methods(node)
             obj.shape = "class"
+
             # inheritance link
             for par_node in node.ancestors(recurs=False):
                 try:
@@ -234,27 +235,41 @@ def extract_relationships(self) -> None:
                 except KeyError:
                     continue
 
-            # associations & aggregations links
-            for name, values in list(node.aggregations_type.items()):
+            # Track processed attributes to avoid duplicates
+            processed_attrs = set()
+
+            # Process in priority order: Composition > Aggregation > Association
+
+            # 1. Composition links (highest priority)
+            for name, values in list(node.compositions_type.items()):
+                if not self.show_attr(name):
+                    continue
                 for value in values:
-                    if not self.show_attr(name):
-                        continue
+                    self.assign_association_relationship(
+                        value, obj, name, "composition"
+                    )
+                    processed_attrs.add(name)
 
+            # 2. Aggregation links (medium priority)
+            for name, values in list(node.aggregations_type.items()):
+                if not self.show_attr(name) or name in processed_attrs:
+                    continue
+                for value in values:
                     self.assign_association_relationship(
                         value, obj, name, "aggregation"
                     )
+                    processed_attrs.add(name)
 
+            # 3. Association links (lowest priority)
             associations = node.associations_type.copy()
-
             for name, values in node.locals_type.items():
                 if name not in associations:
                     associations[name] = values
 
             for name, values in associations.items():
+                if not self.show_attr(name) or name in processed_attrs:
+                    continue
                 for value in values:
-                    if not self.show_attr(name):
-                        continue
-
                     self.assign_association_relationship(
                         value, obj, name, "association"
                     )

pylint/pyreverse/dot_printer.py

@@ -30,12 +30,18 @@ class HTMLLabels(Enum):
 # pylint: disable-next=consider-using-namedtuple-or-dataclass
 ARROWS: dict[EdgeType, dict[str, str]] = {
     EdgeType.INHERITS: {"arrowtail": "none", "arrowhead": "empty"},
-    EdgeType.ASSOCIATION: {
+    EdgeType.COMPOSITION: {
         "fontcolor": "green",
         "arrowtail": "none",
         "arrowhead": "diamond",
         "style": "solid",
     },
+    EdgeType.ASSOCIATION: {
+        "fontcolor": "green",
+        "arrowtail": "none",
+        "arrowhead": "vee",
+        "style": "solid",
+    },
     EdgeType.AGGREGATION: {
         "fontcolor": "green",
         "arrowtail": "none",