0.2.0-alpha.15

Author: DeepDoge

apps/vite/src/app.ts

@@ -1,6 +1,12 @@
 import { Builder, ref, tags } from "@purifyjs/core";
 
-const time = ref(new Date().toLocaleString(), (set) => {
+const s = ref("World");
+
+new Builder(document.body).replaceChildren$(
+    tags.div().replaceChildren$("Hello ", s),
+);
+
+/* const time = ref(new Date().toLocaleString(), (set) => {
     const interval = setInterval(() => set(new Date().toLocaleString()), 1000);
     return () => {
         clearInterval(interval);
@@ -19,3 +25,4 @@ new Builder(document.body).replaceChildren$(
             .setAttribute("foo", "bar"),
     ),
 );
+ */

deno.json

@@ -1,6 +1,6 @@
 {
     "name": "@purifyjs/core",
-    "version": "0.2.0-alpha.14",
+    "version": "0.2.0-alpha.15",
     "workspace": ["./apps/vite", "./apps/size"],
     "exports": {
         ".": "./lib/mod.ts",

lib/tags.ts

@@ -234,14 +234,22 @@ export let Builder: BuilderConstructor = function <T extends Node & Partial<With
                             return value;
                         };
 
+                        // This is the best i can come up with
+                        // Normally if we had a persistent document fragment with lifecyle,
+                        // we could have just wrapped signals with it in the DOM. Not doing these at all.
+                        //
+                        // I can wrap them with an element with lifecycle and give it `display:contents`,
+                        // but that causes other issues in the dx
                         let unwrappedArgs = args.map(unwrap);
                         if (hasSignal) {
                             let computedArgs = computed(() => args.map(unwrap));
                             cleanups[targetName] = node.$effect!(() =>
-                                computedArgs.follow((newArgs) => (node[nodeName] as Fn)(...newArgs))
+                                computedArgs.follow((newArgs) => (node[nodeName] as Fn)(...newArgs), true)
                             );
+                        } else {
+                            (node[nodeName] as Fn)(...unwrappedArgs);
                         }
-                        (node[nodeName] as Fn)(...unwrappedArgs);
+
                         return proxy;
                     }
                 : !(targetName in node)