Skip to content

runtime/lib/query/Join.php:540 gives warnings in PHP7.4 #1079

@michalmagic42

Description

@michalmagic42

Issue: runtime/lib/query/Join.php:540 gives warnings in PHP7.4

The reason is that the implode() method is used against standard:
$joinCondition = sprintf('(%s)', implode($conditions, ' AND '));

For historical reasons, the implode() function supports passing the $glue and $pieces parameters in reverse order from the documented order of arguments. This is inconsistent and makes the argument handling non-standard.

Fix: change the line runtime/lib/query/Join.php:540
From: $joinCondition = sprintf('(%s)', implode($conditions, ' AND '));
To: $joinCondition = sprintf('(%s)', implode(' AND ', $conditions));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions