Extension hook exception

Signed-off-by: Jordan Hollinger <[email protected]>

Author: jhollinger

lib/blueprinter/errors.rb

@@ -2,6 +2,7 @@
 
 module Blueprinter
   module Errors
+    autoload :ExtensionHook, 'blueprinter/errors/extension_hook'
     autoload :InvalidBlueprint, 'blueprinter/errors/invalid_blueprint'
     autoload :UnknownPartial, 'blueprinter/errors/unknown_partial'
     autoload :UnknownView, 'blueprinter/errors/unknown_view'

lib/blueprinter/errors/extension_hook.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Blueprinter
+  module Errors
+    class ExtensionHook < StandardError
+      attr_reader :extension, :hook, :message
+
+      def initialize(extension, hook, message)
+        @extension = extension
+        @hook = hook
+        @message = message
+      end
+    end
+  end
+end

lib/blueprinter/hooks.rb

@@ -10,6 +10,7 @@ def initialize(extensions)
         ext.class.hooks.each { |hook| @hooks[hook] << ext }
       end
       @hooks.freeze
+      @reversed_hooks ||= @hooks.transform_values(&:reverse).freeze
       @around_hook_registered = registered? :around_hook
     end
 
@@ -120,7 +121,6 @@ def reduce_into(hook, ctx, attr)
     #
     def around(hook, ctx)
       result = nil
-      @reversed_hooks ||= @hooks.transform_values(&:reverse).freeze
       @reversed_hooks.fetch(hook).reduce(-> { result = yield }) do |f, ext|
         proc do
           yields = 0
@@ -130,7 +130,7 @@ def around(hook, ctx)
           end
           if yields != 1
             msg = "Extension hook '#{ext.class.name}##{hook}' should have yielded 1 time, but yielded #{yields} times"
-            raise BlueprinterError, msg
+            raise Errors::ExtensionHook.new(ext, hook, msg)
           end
         end
       end.call

lib/blueprinter/v2/serializer.rb

@@ -91,7 +91,6 @@ def serialize_collection(collection, depth:)
         @hooks.reduce_into(:collection_output, ctx, :result)
       end
 
-      # rubocop:disable Metrics/MethodLength
       def serialize(object, depth:)
         if @run_blueprint_input
           ctx = Context::Object.new(@blueprint, @fields, @options, object, depth)
@@ -105,15 +104,11 @@ def serialize(object, depth:)
           ctx.value = ctx.field.value_proc ? proc_value(ctx) : @hooks.call(field_conf.extractor, :extract_value, ctx)
           field_conf.serialize(ctx, acc)
         end
+        return result unless @run_blueprint_output
 
-        if @run_blueprint_output
-          ctx = Context::Result.new(@blueprint, @fields, @options, object, result, depth)
-          @hooks.reduce_into(:blueprint_output, ctx, :result)
-        else
-          result
-        end
+        ctx = Context::Result.new(@blueprint, @fields, @options, object, result, depth)
+        @hooks.reduce_into(:blueprint_output, ctx, :result)
       end
-      # rubocop:enable Metrics/MethodLength
 
       # @param ctx [Blueprinter::V2::Context::Field]
       def proc_value(ctx)

spec/extensions/hooks_spec.rb

@@ -299,7 +299,7 @@ def around_serialize_object(_ctx); end
       end
       ctx = object_ctx.new(serializer.blueprint, serializer.fields, {}, object)
       hooks = described_class.new [ext.new]
-      expect { hooks.around(:around_serialize_object, ctx) { 42 } }.to raise_error Blueprinter::BlueprinterError
+      expect { hooks.around(:around_serialize_object, ctx) { 42 } }.to raise_error Blueprinter::Errors::ExtensionHook
     end
 
     it 'raises if a hook yields more than once' do
@@ -311,7 +311,7 @@ def around_serialize_object(_ctx)
       end
       ctx = object_ctx.new(serializer.blueprint, serializer.fields, {}, object)
       hooks = described_class.new [ext.new]
-      expect { hooks.around(:around_serialize_object, ctx) { 42 } }.to raise_error Blueprinter::BlueprinterError
+      expect { hooks.around(:around_serialize_object, ctx) { 42 } }.to raise_error Blueprinter::Errors::ExtensionHook
     end
   end
 end

spec/v2/serializer_spec.rb

@@ -52,7 +52,9 @@
     let(:name_of_extractor) do
       test = self
       Class.new(Blueprinter::V2::Extensions::Core::Extractor) do
-        def initialize(prefix: 'Name') = @prefix = prefix
+        def initialize(prefix: 'Name') = @tmp_prefix = prefix
+
+        def blueprint_setup(_ctx) = @prefix = @tmp_prefix
 
         def extract_value(ctx)
           case ctx.field