Skip to content

trident validate should check LF-line endings  #311

@stschiff

Description

@stschiff

We recently came across an issue where I accidentally committed a Janno-file that had Windows line endings (CRLF) (see poseidon-framework/community-archive#214). Checksums were computed based on these files and committed, and the package validated. We only caught this because git converted the line endings implicitly into LF, which in turn changed the file and invalidated the checksum.

Whether or not we divide to change git-attributes (see poseidon-framework/community-archive#215), we should build in a check within trident validate that checks for line endings in all text-files that are checksum-validated, including .ind, .fam, .snp, .bim, .vcf (in the future), .geno, .bib, .janno.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions