Fix Windows wheel missing libscalene.dll for memory profiling

The Windows wheels on PyPI were missing libscalene.dll because the CI
workflow did not install CMake, causing the DLL build to be silently
skipped.

Changes:
- Add CMake installation step for Windows builds in CI workflow
- Add verification step to fail build if libscalene.dll is missing
- Improve setup.py Windows build with explicit architecture detection
- Add more search paths for built DLL and better debug output

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: emeryberger

.github/workflows/build-and-upload.yml

@@ -117,6 +117,11 @@ jobs:
         if: matrix.os == 'macos-latest'
         run: sudo rm -Rf /Library/Developer/CommandLineTools/SDKs/*
 
+      - name: Install CMake on Windows
+        # CMake is required to build libscalene.dll for memory profiling on Windows
+        if: matrix.os == 'windows-latest'
+        run: choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' -y
+
       - name: Build source dist
         if: matrix.upload_source
         run: make sdist
@@ -139,6 +144,33 @@ jobs:
               fi
             done
           done
+
+      - name: Check that libscalene.dll is included in Windows wheel
+        if: matrix.os == 'windows-latest'
+        shell: python
+        run: |
+          import zipfile
+          import glob
+          import sys
+
+          wheels = glob.glob('dist/*.whl')
+          if not wheels:
+              print("ERROR: No wheel files found")
+              sys.exit(1)
+
+          for whl in wheels:
+              print(f"Checking {whl}...")
+              with zipfile.ZipFile(whl, 'r') as z:
+                  files = z.namelist()
+                  dll_files = [f for f in files if 'libscalene.dll' in f]
+                  if dll_files:
+                      print(f"  Found: {dll_files}")
+                  else:
+                      print(f"  ERROR: libscalene.dll not found in wheel!")
+                      print(f"  Files in wheel: {[f for f in files if f.endswith(('.dll', '.pyd', '.so'))]}")
+                      sys.exit(1)
+
+          print("All Windows wheels contain libscalene.dll")
   
       - name: Non-release (dev) upload
         if: github.event_name != 'release'

setup.py

@@ -248,15 +248,33 @@ def build_libscalene_windows(self):
             return
 
         try:
+            # Detect architecture for Windows builds
+            import platform
+            machine = platform.machine().lower()
+            if machine in ('amd64', 'x86_64'):
+                cmake_arch = 'x64'
+            elif machine in ('arm64', 'aarch64'):
+                cmake_arch = 'ARM64'
+            else:
+                cmake_arch = None
+                print(f"Warning: Unknown architecture '{machine}', using default CMake generator")
+
             # Configure with CMake
-            self.spawn([
+            cmake_config = [
                 'cmake',
                 '-S', '.',
                 '-B', cmake_build_dir,
                 '-DCMAKE_BUILD_TYPE=Release',
                 f'-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={scalene_temp}',
                 f'-DCMAKE_RUNTIME_OUTPUT_DIRECTORY={scalene_temp}',
-            ])
+            ]
+
+            # Add architecture-specific options for Visual Studio generator
+            if cmake_arch:
+                cmake_config.extend(['-A', cmake_arch])
+                print(f"Building libscalene.dll for {cmake_arch} architecture")
+
+            self.spawn(cmake_config)
 
             # Build
             self.spawn([
@@ -266,19 +284,28 @@ def build_libscalene_windows(self):
             ])
 
             # Copy the DLL
-            # On Windows, CMake may put the DLL in a Release subdirectory
+            # On Windows, CMake may put the DLL in various locations depending on
+            # how the build is configured. Check all possible locations.
+            project_dir = path.dirname(path.abspath(__file__))
             possible_paths = [
                 path.join(scalene_temp, libscalene),
                 path.join(scalene_temp, 'Release', libscalene),
                 path.join(cmake_build_dir, 'Release', libscalene),
+                path.join(cmake_build_dir, libscalene),
+                # CMakeLists.txt may override output dir to project's scalene folder
+                path.join(project_dir, 'scalene', libscalene),
+                path.join(project_dir, 'scalene', 'Release', libscalene),
             ]
 
             for src_path in possible_paths:
                 if path.exists(src_path):
+                    print(f"Found {libscalene} at {src_path}")
                     self.copy_file(src_path, path.join(scalene_lib, libscalene))
+                    print(f"Copied to {path.join(scalene_lib, libscalene)}")
                     break
             else:
                 print(f"Warning: Could not find {libscalene} after build")
+                print(f"Searched in: {possible_paths}")
 
         except Exception as e:
             print(f"Warning: Failed to build libscalene on Windows: {e}")