From 4be2794e7a5dcf8eb0a5a617b09f74f1e926c3b6 Mon Sep 17 00:00:00 2001 From: Brian Durand Date: Thu, 15 Nov 2012 15:56:42 -0800 Subject: [PATCH] replace destructive gsub! with gsub so campfire repository variable isn't altered. --- lib/capfire.rb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/capfire.rb b/lib/capfire.rb index 335e657..e2e8fde 100644 --- a/lib/capfire.rb +++ b/lib/capfire.rb @@ -55,9 +55,7 @@ def deployer # Link to github's excellent Compare View def github_compare_url(repo_url, first_commit, last_commit) - repo_url.gsub!(/git@/, 'http://') - repo_url.gsub!(/\.com:/,'.com/') - repo_url.gsub!(/\.git/, '') + repo_url = repo_url.gsub(/git@/, 'http://').gsub(/\.com:/,'.com/').gsub(/\.git/, '') "#{repo_url}/compare/#{first_commit}...#{last_commit}" end @@ -69,18 +67,15 @@ def default_idiot_message def idiot_message(application) message = self.config["idiot_message"] message = default_idiot_message unless message - message.gsub!(/#deployer#/, self.deployer) - message.gsub!(/#application#/, application) + message = message.gsub(/#deployer#/, self.deployer).gsub(/#application#/, application) message end # Message to post to campfire on deploy def deploy_message(args,compare_url, application) message = self.config["message"] - message.gsub!(/#deployer#/, deployer) - message.gsub!(/#application#/, application) - message.gsub!(/#args#/, args) - message.gsub!(/#compare_url#/, compare_url) + message = message.gsub(/#deployer#/, deployer).gsub(/#application#/, application) + message = message.gsub(/#args#/, args).gsub(/#compare_url#/, compare_url) message end