Support Node.js v21 (#1834)

mcollina · web-flow · commit 3dd1d4d47642 · 2023-10-23T19:11:52.000+02:00
Signed-off-by: Matteo Collina &lt;hello@matteocollina.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -42,7 +42,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macOS-latest, windows-latest, ubuntu-latest]
-        node-version: [14, 16, 18, 19, 20]
+        node-version: [14, 16, 18, 19, 20, 21]
         exclude:
           - os: windows-latest
             node-version: 14
diff --git a/lib/proto.js b/lib/proto.js
@@ -226,7 +226,7 @@ function flush (cb) {
 
   const stream = this[streamSym]
 
-  if ('flush' in stream) {
+  if (typeof stream.flush === 'function') {
     stream.flush(cb || noop)
   } else if (cb) cb()
 }

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ function flush (cb) {`
`226`	`226`
`227`	`227`	`const stream = this[streamSym]`
`228`	`228`
`229`		`- if ('flush' in stream) {`
	`229`	`+ if (typeof stream.flush === 'function') {`
`230`	`230`	`stream.flush(cb \|\| noop)`
`231`	`231`	`} else if (cb) cb()`
`232`	`232`	`}`