Skip to content

Files downloaded by phrase pull should end with newline #130

@dkimmich-onventis

Description

@dkimmich-onventis

Files should end with newline, otherwise there can be issues with version control, such as unexpected results of diff and blame. When using phrase pull however, the file which is downloaded doesn't contain a final newline. If a code style tool like prettier is used, this causes a warning and can lead to additional work by the developer to either add a newline every time the file is downloaded, or exclude translation files from formatting.

The proposed solution is to add a final newline to the downloaded files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions