Prevent unnecessary work around parametersAcceptor->getParameters() call-sites

Author: staabm

build/PHPStan/Build/AttributeNamedArgumentsRule.php

@@ -48,13 +48,12 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$parameters = $variants[0]->getParameters();
-
 		foreach ($node->args as $arg) {
 			if ($arg->name !== null) {
 				break;
 			}
 
+			$parameters = $variants[0]->getParameters();
 			return [
 				RuleErrorBuilder::message(sprintf('Attribute %s is not using named arguments.', $node->name->toString()))
 					->identifier('phpstan.attributeWithoutNamedArguments')

src/Analyser/ArgumentsNormalizer.php

@@ -193,8 +193,6 @@ public static function reorderArgs(ParametersAcceptor $parametersAcceptor, array
 			return [];
 		}
 
-		$signatureParameters = $parametersAcceptor->getParameters();
-
 		$hasNamedArgs = false;
 		foreach ($callArgs as $arg) {
 			if ($arg->name !== null) {
@@ -208,6 +206,7 @@ public static function reorderArgs(ParametersAcceptor $parametersAcceptor, array
 
 		$hasVariadic = false;
 		$argumentPositions = [];
+		$signatureParameters = $parametersAcceptor->getParameters();
 		foreach ($signatureParameters as $i => $parameter) {
 			if ($hasVariadic) {
 				// variadic parameter must be last

src/Analyser/MutatingScope.php

@@ -2398,7 +2398,8 @@ private function enterFunctionLike(
 	{
 		$parametersByName = [];
 
-		foreach ($functionReflection->getParameters() as $parameter) {
+		$functionParameters = $functionReflection->getParameters();
+		foreach ($functionParameters as $parameter) {
 			$parametersByName[$parameter->getName()] = $parameter;
 		}
 
@@ -2411,7 +2412,7 @@ private function enterFunctionLike(
 			$nativeExpressionTypes = $this->nativeExpressionTypes;
 		}
 
-		foreach ($functionReflection->getParameters() as $parameter) {
+		foreach ($functionParameters as $parameter) {
 			$parameterType = $parameter->getType();
 
 			if ($parameterType instanceof ConditionalTypeForParameter) {

src/Reflection/ParametersAcceptorSelector.php

@@ -87,8 +87,6 @@ public static function selectFromArgs(
 		) {
 			$arrayMapArgs = $args[0]->value->getAttribute(ArrayMapArgVisitor::ATTRIBUTE_NAME);
 			if ($arrayMapArgs !== null) {
-				$acceptor = $parametersAcceptors[0];
-				$parameters = $acceptor->getParameters();
 				$callbackParameters = [];
 				foreach ($arrayMapArgs as $arg) {
 					$argType = $scope->getType($arg->value);
@@ -107,6 +105,8 @@ public static function selectFromArgs(
 					}
 				}
 
+				$acceptor = $parametersAcceptors[0];
+				$parameters = $acceptor->getParameters();
 				if (isset($parameters[0])) {
 					$parameters[0] = new NativeParameterReflection(
 						$parameters[0]->getName(),

src/Rules/Functions/ParameterCastableToStringRule.php

@@ -71,7 +71,6 @@ public function processNode(Node $node, Scope $scope): array
 		);
 
 		$errorMessage = 'Parameter %s of function %s expects an array of values castable to string, %s given.';
-		$functionParameters = $parametersAcceptor->getParameters();
 
 		if (in_array($functionName, $checkAllArgsFunctions, true)) {
 			$argsToCheck = $origArgs;
@@ -92,7 +91,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$errors = [];
-
+		$functionParameters = $parametersAcceptor->getParameters();
 		foreach ($argsToCheck as $argIdx => $arg) {
 			$error = $this->parameterCastableToStringCheck->checkParameter(
 				$arg,

src/Rules/Functions/SortParameterCastableToStringRule.php

@@ -68,8 +68,6 @@ public function processNode(Node $node, Scope $scope): array
 			$functionReflection->getNamedArgumentsVariants(),
 		);
 
-		$functionParameters = $parametersAcceptor->getParameters();
-
 		$normalizedFuncCall = ArgumentsNormalizer::reorderFuncArguments($parametersAcceptor, $node);
 
 		if ($normalizedFuncCall === null) {
@@ -81,6 +79,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		$functionParameters = $parametersAcceptor->getParameters();
 		$argsToCheck = [0 => $normalizedArgs[0]];
 		$flags = null;
 		if (array_key_exists(1, $normalizedArgs)) {

src/Rules/Methods/MethodSignatureRule.php

@@ -110,16 +110,18 @@ public function processNode(Node $node, Scope $scope): array
 				$errors[] = $builder->build();
 			}
 
-			$parameterResults = $this->checkParameterTypeCompatibility($declaringClass, $method->getParameters(), $parentVariant->getParameters());
+			$methodParameters = $method->getParameters();
+			$parentVariantParameters = $parentVariant->getParameters();
+			$parameterResults = $this->checkParameterTypeCompatibility($declaringClass, $methodParameters, $parentVariantParameters);
 			foreach ($parameterResults as $parameterIndex => [$parameterResult, $parameterType, $parentParameterType]) {
 				if ($parameterResult->yes()) {
 					continue;
 				}
 				if (!$parameterResult->no() && !$this->reportMaybes) {
 					continue;
 				}
-				$parameter = $method->getParameters()[$parameterIndex];
-				$parentParameter = $parentVariant->getParameters()[$parameterIndex];
+				$parameter = $methodParameters[$parameterIndex];
+				$parentParameter = $parentVariantParameters[$parameterIndex];
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'Parameter #%d $%s (%s) of method %s::%s() should be %s with parameter $%s (%s) of method %s::%s()',
 					$parameterIndex + 1,

src/Type/Php/ArrayCountValuesDynamicReturnTypeExtension.php

@@ -11,8 +11,8 @@
 use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
 use PHPStan\Type\IntegerRangeType;
-use PHPStan\Type\IntersectionType;
 use PHPStan\Type\IntegerType;
+use PHPStan\Type\IntersectionType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;