Skip to content

Commit 26139c2

Browse files
phmatrayclaude
andcommitted
fix: add explicit version to dotnet pack and fix feat! detection
- Add -p:Version parameter to dotnet pack to override MinVer - Add feat!:major and fix!:major rules to properly detect breaking changes - This ensures v3.0.0 packages are created with correct version 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
1 parent 2b451e3 commit 26139c2

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/ci-cd.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ jobs:
8282
default_bump: ${{ steps.check_tags.outputs.has_tags == 'false' && 'major' || 'false' }}
8383
custom_release_rules: |
8484
breaking:major,
85+
feat!:major,
8586
feat:minor,
87+
fix!:major,
8688
fix:patch,
8789
perf:patch,
8890
revert:patch,
@@ -142,9 +144,10 @@ jobs:
142144
- name: Pack NuGet packages
143145
if: steps.should_release.outputs.new_release == 'true'
144146
run: |
145-
dotnet pack src/TechnicalAnalysis.Common/TechnicalAnalysis.Common.csproj --configuration Release --no-build --output ./artifacts
146-
dotnet pack src/TechnicalAnalysis.Functions/TechnicalAnalysis.Functions.csproj --configuration Release --no-build --output ./artifacts
147-
dotnet pack src/TechnicalAnalysis.Candles/TechnicalAnalysis.Candles.csproj --configuration Release --no-build --output ./artifacts
147+
VERSION=${{ steps.get_version.outputs.new_version }}
148+
dotnet pack src/TechnicalAnalysis.Common/TechnicalAnalysis.Common.csproj --configuration Release --no-build --output ./artifacts -p:Version=$VERSION
149+
dotnet pack src/TechnicalAnalysis.Functions/TechnicalAnalysis.Functions.csproj --configuration Release --no-build --output ./artifacts -p:Version=$VERSION
150+
dotnet pack src/TechnicalAnalysis.Candles/TechnicalAnalysis.Candles.csproj --configuration Release --no-build --output ./artifacts -p:Version=$VERSION
148151
149152
- name: Install NuGet validator
150153
if: steps.should_release.outputs.new_release == 'true'

0 commit comments

Comments
 (0)