Post integration of the new implementation

[Ducasse]

Kasper I'm fixing several points:

• I added a dev branch and we should do PR on this branch so that after once this is ok we can merge into master (= into pharo).
• We should not use Smalltalk ui icons but self iconNamed:

I'm trying to fix the class comments but I cannot.

• how do we decide to internalize the file? because I do not get when I decide it.

• I have no idea what is openOnCustomHelp: aDescription there is no comment and no sender.

• openPharoRepo just breaks on me.

• open
  "Open a HelpBrowser on the internalized docs."
  

  ^ self error: 'We need to define a default starting point'

I have no idea what is a default starting point and how to do it so the error does not help the user at all.

• the following raises a DNU:

openBrowser
	<script>
	StHelpBrowserPresenter openTopic: self githubTopics 

after I press reset, it is working.
Before I was using StHelpBrowser open ....

[Ducasse]

To me this method

openBrowser
	<script>
	StHelpBrowserPresenter openTopic: self githubTopics 

should be moved to StHelpBrowserPresenter because users do not care about the builder.
It should probably named openPharoDocFromGit or something like that.

[Ducasse]

• I could not get how to use StTopicFromFileFolderBuilder to build from local files.

[Ducasse]

I saw that it is used in `StHelpBrowserPresenter class>> #openOnHelpFolder: so I added a class comment.

[Ducasse]

• I could not understand why the visitor is holding an instance of itself.

StTopicBuilderVisitor >> helpTopicVisitor
	
	helpTopicVisitor ifNil: [ helpTopicVisitor := StTopicBuilderVisitor ].
	^ helpTopicVisitor

[Ducasse]

This looks fishy to me.

[Ducasse]

I removed it and it works.