Skip to content

Commit 7533b58

Browse files
authored
Merge branch 'master' into feature/add_part_url
2 parents 281ee90 + 7aff2e0 commit 7533b58

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

paperless/objects/customers.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,14 @@ class Account(
127127
_json_encoder = AccountEncoder
128128

129129
name: str = attr.ib(validator=attr.validators.instance_of(str))
130-
country_code: str = attr.ib(validator=attr.validators.instance_of((str, object)))
131130

132131
# not required for instantiation
133132
billing_addresses = attr.ib(
134133
default=[], converter=optional_convert(convert_iterable(BillingAddress))
135134
)
135+
country_code: str = attr.ib(
136+
default=NO_UPDATE, validator=attr.validators.instance_of((str, object))
137+
)
136138
created = attr.ib(
137139
default=NO_UPDATE, validator=(attr.validators.instance_of((str, object)))
138140
)
@@ -312,12 +314,14 @@ class Contact(
312314
email: str = attr.ib(validator=attr.validators.instance_of(str))
313315
first_name: str = attr.ib(validator=attr.validators.instance_of(str))
314316
last_name: str = attr.ib(validator=attr.validators.instance_of(str))
315-
country_code: str = attr.ib(validator=attr.validators.instance_of((str, object)))
316317

317318
# not required for instantiation
318319
address = attr.ib(
319320
default=NO_UPDATE, converter=optional_convert(convert_cls(Address))
320321
)
322+
country_code: str = attr.ib(
323+
default=NO_UPDATE, validator=attr.validators.instance_of((str, object))
324+
)
321325
created = attr.ib(
322326
default=NO_UPDATE, validator=(attr.validators.instance_of((str, object)))
323327
)

tests/unit/test_contacts.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@ def setUp(self):
1919
with open('tests/unit/mock_data/contact.json') as data_file:
2020
self.mock_contact_json = json.load(data_file)
2121

22+
def test_create_contact_obj_with_only_required_args(self):
23+
# should not raise any error
24+
Contact(
25+
account_id = 1,
26+
email = "[email protected]",
27+
first_name = "Contact",
28+
last_name = "Paperless"
29+
)
30+
2231
def test_get_contact(self):
2332
self.client.get_resource = MagicMock(return_value=self.mock_contact_json)
2433
c = Contact.get(1)
@@ -94,6 +103,10 @@ def setUp(self):
94103
with open('tests/unit/mock_data/account.json') as data_file:
95104
self.mock_account_json = json.load(data_file)
96105

106+
def test_create_account_with_only_required_args(self):
107+
# should not raise any error
108+
Account(name="Account Name")
109+
97110
def test_get_account(self):
98111
self.client.get_resource = MagicMock(return_value=self.mock_account_json)
99112
a = Account.get(1)

0 commit comments

Comments
 (0)