Make internet access optional for image prep

[wfchandler]

Currently we bail out if the host is unable to ping 1.1.1.1. It would be useful to make the SSH and hostkey steps optional if internet access is unavailable in the customer's environment.

[qdzlug]

Spent way too much time missing this, but if we are using qemu + SLiRP networking ICMP doesn't work:

Note - if you are using the (default) SLiRP user networking, then ping (ICMP) will not work, though TCP and UDP will. Don't try to use ping to test your QEMU network configuration!

We should use a different method to test internet connectivity.

[qdzlug]

This approach just tries to hit our website and if it can we get a thumbs up on the internet connectivity.

#region Wait for internet access
$timeout = New-TimeSpan -Seconds 30
$stopwatch = [System.Diagnostics.Stopwatch]::StartNew()
$connected = $false

do {
    $ping = Test-NetConnection -ComputerName "www.oxide.computer" -Port 443
    if ($ping.TcpTestSucceeded) {
        $connected = $true
        break
    }

    Start-Sleep -Seconds 1
} while ($stopwatch.Elapsed -lt $timeout)

if (-not $connected) {
    Write-Host "No internet connectivity"
    exit 1
} else {
    Write-Host "Internet connection established"
}
#endregion

[wfchandler]

Great, let's get a PR with your fix @qdzlug

[qdzlug]

Just realized that I only fixed one part of this issue (the ping); I'm not addressing the issue where the customer does not have connectivity.

The concern is that if we do not install the SSH server and the user doesn't change anything, they won't be able to log in to the resulting vm - since the way to log in via RDP is "ssh in with your key, and then do a net user to change the password".

Now, this can be worked around by supplying the user credentials in the cloud_init file.

So - I see a few options:

1. Rework the script to provide the ssh package (ie, have the user download it however they need to so we're not reaching out to the internet).
2. Let the script fail, but add in logic to tell them why it failed and how to fix it.
3. Either just skip over the install if there is no connectivity and print a message, or the same but have a dialog that stops the install at that point and asks for what to do.

I don't have a strong preference for any of these - although 2/3 are probably easiest, but 1 is not super hard.

[wfchandler]

1 or 2 sound the best to me, users in a hurry may just gloss over a warning message.

Re 1, if we're requiring the user to obtain the SSH package themselves, then it's essentially the same as 2, right? I feel like I'm missing something.

[qdzlug]

Basically - I started down the "air gap" line of reasoning and came up with that, but in reality I'd code it to try the internet, look for the package locally (say on the virtio drive, and then fail.

This will get rid of the case where it appears to hang but we don't notify you of that fact so you spend a few hours waiting for it to finish until you realize....oh. That was me.