Use tsgo, upgrade oxlint (#3075)

* switch type checker to tsgo

* simplify tsconfig a bit

* upgrade oxlint and tsgolint

* turn on more lint rules

Author: david-crespo

.github/workflows/lintBuildTest.yml

@@ -41,7 +41,7 @@ jobs:
           path: node_modules
           key: modules-${{ hashFiles('package-lock.json', 'patches/**') }}
       - name: Typecheck
-        run: npx tsc
+        run: npx tsgo
       - name: Lint
         run: npm run lint
       - name: Check formatting

.gitignore

@@ -23,6 +23,7 @@ deno.lock
 
 .env
 .eslintcache
+*.tsbuildinfo
 
 # System Files
 .DS_Store

.oxlintrc.json

@@ -60,6 +60,24 @@
     "radix": "error",
 
     "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/consistent-type-assertions": "error",
+    "prefer-const": "error",
+    "import/no-nodejs-modules": "error",
+    "react/no-this-in-sfc": "error",
+    "@typescript-eslint/no-invalid-void-type": "error",
+    "unicorn/relative-url-style": "error",
+
+    // suspicious rules (cherry-picked)
+    "no-extra-bind": "error",
+    "no-unneeded-ternary": "error",
+    "no-useless-concat": "error",
+    "no-useless-constructor": "error",
+    "import/no-absolute-path": "error",
+    "import/no-self-import": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
+    "@typescript-eslint/no-unnecessary-type-constraint": "error",
+    "@typescript-eslint/no-unnecessary-template-expression": "error",
+    "@typescript-eslint/no-confusing-non-null-assertion": "error",
 
     // TypeScript rules (currently disabled but available)
     "@typescript-eslint/no-floating-promises": "off",
@@ -80,6 +98,12 @@
         "import/no-default-export": "off"
       }
     },
+    {
+      "files": ["**/*.spec.ts", "**/*.config.ts", "**/*.config.mjs", "tools/**/*"],
+      "rules": {
+        "import/no-nodejs-modules": "off"
+      }
+    },
     {
       // catch unawaited Playwright calls in e2e tests
       "files": ["test/e2e/**/*.ts"],

README.md

@@ -122,7 +122,7 @@ To debug end-to-end failures on CI, check out the branch with the failure and ru
 | `npm test`               | Vitest unit tests                                                                  |
 | `npm run e2ec`           | Run Playwright E2E tests in Chrome only                                            |
 | `npm run lint`           | ESLint                                                                             |
-| `npx tsc`                | Check types                                                                        |
+| `npm run tsc`            | Check types                                                                        |
 | `npm run ci`             | Lint, tests (unit and e2e), and types                                              |
 | `npm run fmt`            | Format everything. Rarely necessary thanks to editor integration                   |
 | `npm run gen-api`        | Generate API client (see [`docs/update-pinned-api.md`](docs/update-pinned-api.md)) |

app/forms/disk-create.tsx

@@ -432,7 +432,7 @@ const SnapshotSelectField = ({ control }: { control: Control<DiskCreateForm> })
         const formattedSize = filesize(i.size, { base: 2, output: 'object' })
         return {
           value: i.id,
-          selectedLabel: `${i.name}`,
+          selectedLabel: i.name,
           label: (
             <>
               <div>{i.name}</div>

app/forms/firewall-rules-common.tsx

@@ -301,7 +301,7 @@ const icmpTypeItems = [
   ...Object.entries(ICMP_TYPES).map(([type, name]) => ({
     value: type,
     label: `${type} - ${name}`,
-    selectedLabel: `${type}`,
+    selectedLabel: type,
   })),
 ]
 

app/forms/firewall-rules-create.tsx

@@ -81,7 +81,8 @@ export default function CreateFirewallRuleForm() {
 
   const updateRules = useApiMutation(api.vpcFirewallRulesUpdate, {
     onSuccess(updatedRules) {
-      const newRule = updatedRules.rules[updatedRules.rules.length - 1]
+      // We just appended a rule, so the response list is non-empty
+      const newRule = updatedRules.rules.at(-1)!
       queryClient.invalidateEndpoint('vpcFirewallRulesView')
       // prettier-ignore
       addToast(<>Firewall rule <HL>{newRule.name}</HL> created</>)

app/ui/lib/DateField.tsx

@@ -117,7 +117,7 @@ function DateSegment({
     placeholder = segment.placeholder
   }
 
-  const readOnly = segmentProps['aria-readonly'] ? true : false
+  const readOnly = !!segmentProps['aria-readonly']
 
   return (
     <div
@@ -135,7 +135,7 @@ function DateSegment({
       )}
       // Segment props turns this into a focusable element
       // @ts-expect-error
-      disabled={readOnly ? true : false}
+      disabled={readOnly}
     >
       {/* Always reserve space for the placeholder, to prevent layout shift when editing. */}
       <span

mock-api/msw/handlers.ts

@@ -665,7 +665,7 @@ export const handlers = makeHandlers({
             name,
             description,
             instance_id: instanceId,
-            primary: i === 0 ? true : false,
+            primary: i === 0,
             mac: '00:00:00:00:00:00',
             ip_stack: ip_config
               ? resolveIpStack(ip_config)

mock-api/msw/util.ts

@@ -77,7 +77,7 @@ export const paginated = <P extends PaginateOptions, I extends { id: string }>(
 
   return {
     items: items.slice(startIndex, startIndex + limit),
-    next_page: `${items[startIndex + limit].id}`,
+    next_page: items[startIndex + limit].id,
   }
 }