turn on more lint rules

Author: david-crespo

.oxlintrc.json

@@ -60,6 +60,24 @@
     "radix": "error",
 
     "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/consistent-type-assertions": "error",
+    "prefer-const": "error",
+    "import/no-nodejs-modules": "error",
+    "react/no-this-in-sfc": "error",
+    "@typescript-eslint/no-invalid-void-type": "error",
+    "unicorn/relative-url-style": "error",
+
+    // suspicious rules (cherry-picked)
+    "no-extra-bind": "error",
+    "no-unneeded-ternary": "error",
+    "no-useless-concat": "error",
+    "no-useless-constructor": "error",
+    "import/no-absolute-path": "error",
+    "import/no-self-import": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
+    "@typescript-eslint/no-unnecessary-type-constraint": "error",
+    "@typescript-eslint/no-unnecessary-template-expression": "error",
+    "@typescript-eslint/no-confusing-non-null-assertion": "error",
 
     // TypeScript rules (currently disabled but available)
     "@typescript-eslint/no-floating-promises": "off",
@@ -80,6 +98,12 @@
         "import/no-default-export": "off"
       }
     },
+    {
+      "files": ["**/*.spec.ts", "**/*.config.ts", "**/*.config.mjs", "tools/**/*"],
+      "rules": {
+        "import/no-nodejs-modules": "off"
+      }
+    },
     {
       // catch unawaited Playwright calls in e2e tests
       "files": ["test/e2e/**/*.ts"],

app/forms/disk-create.tsx

@@ -432,7 +432,7 @@ const SnapshotSelectField = ({ control }: { control: Control<DiskCreateForm> })
         const formattedSize = filesize(i.size, { base: 2, output: 'object' })
         return {
           value: i.id,
-          selectedLabel: `${i.name}`,
+          selectedLabel: i.name,
           label: (
             <>
               <div>{i.name}</div>

app/forms/firewall-rules-common.tsx

@@ -301,7 +301,7 @@ const icmpTypeItems = [
   ...Object.entries(ICMP_TYPES).map(([type, name]) => ({
     value: type,
     label: `${type} - ${name}`,
-    selectedLabel: `${type}`,
+    selectedLabel: type,
   })),
 ]
 

app/ui/lib/DateField.tsx

@@ -117,7 +117,7 @@ function DateSegment({
     placeholder = segment.placeholder
   }
 
-  const readOnly = segmentProps['aria-readonly'] ? true : false
+  const readOnly = !!segmentProps['aria-readonly']
 
   return (
     <div
@@ -135,7 +135,7 @@ function DateSegment({
       )}
       // Segment props turns this into a focusable element
       // @ts-expect-error
-      disabled={readOnly ? true : false}
+      disabled={readOnly}
     >
       {/* Always reserve space for the placeholder, to prevent layout shift when editing. */}
       <span

mock-api/msw/handlers.ts

@@ -665,7 +665,7 @@ export const handlers = makeHandlers({
             name,
             description,
             instance_id: instanceId,
-            primary: i === 0 ? true : false,
+            primary: i === 0,
             mac: '00:00:00:00:00:00',
             ip_stack: ip_config
               ? resolveIpStack(ip_config)

mock-api/msw/util.ts

@@ -77,7 +77,7 @@ export const paginated = <P extends PaginateOptions, I extends { id: string }>(
 
   return {
     items: items.slice(startIndex, startIndex + limit),
-    next_page: `${items[startIndex + limit].id}`,
+    next_page: items[startIndex + limit].id,
   }
 }