Skip to content

Commit 0c27edf

Browse files
owineclaude
andcommitted
fix(deploy): resolve shellcheck SC2235 warnings in conditional expressions
Replace subshell grouping with bash compound conditionals for better performance and to satisfy shellcheck SC2235. Changed: - ([ condition ] || [ condition ]) → [[ (condition || condition) ]] - Use [[ ]] instead of [ ] for compound conditionals - Eliminates subshell overhead in deployment status reporting Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
1 parent 1883416 commit 0c27edf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -789,15 +789,15 @@ jobs:
789789
echo "✅ Repository already at target commit"
790790
echo "📋 Target stacks: $STACK_LIST"
791791
echo "🔄 SHA: ${{ inputs.target-ref }}"
792-
elif [ "${{ inputs.force-deploy }}" = "true" ] && ([ "${{ steps.deploy-existing.outcome }}" == "success" ] || [ "${{ steps.deploy-existing.outcome }}" == "skipped" ]) && ([ "${{ steps.deploy-new.outcome }}" == "success" ] || [ "${{ steps.deploy-new.outcome }}" == "skipped" ]) && [ "${{ steps.health.outcome }}" == "success" ]; then
792+
elif [[ "${{ inputs.force-deploy }}" = "true" && ("${{ steps.deploy-existing.outcome }}" == "success" || "${{ steps.deploy-existing.outcome }}" == "skipped") && ("${{ steps.deploy-new.outcome }}" == "success" || "${{ steps.deploy-new.outcome }}" == "skipped") && "${{ steps.health.outcome }}" == "success" ]]; then
793793
echo "🔄 **FORCE DEPLOYMENT SUCCESSFUL**"
794794
echo "✅ All stacks force-deployed and healthy"
795795
echo "📋 Deployed stacks: $STACK_LIST"
796796
echo "🔄 SHA: ${{ inputs.target-ref }}"
797797
if [ "${{ steps.cleanup.outcome }}" == "success" ]; then
798798
echo "🧹 Cleanup completed successfully"
799799
fi
800-
elif ([ "${{ steps.deploy-existing.outcome }}" == "success" ] || [ "${{ steps.deploy-existing.outcome }}" == "skipped" ]) && ([ "${{ steps.deploy-new.outcome }}" == "success" ] || [ "${{ steps.deploy-new.outcome }}" == "skipped" ]) && [ "${{ steps.health.outcome }}" == "success" ]; then
800+
elif [[ ("${{ steps.deploy-existing.outcome }}" == "success" || "${{ steps.deploy-existing.outcome }}" == "skipped") && ("${{ steps.deploy-new.outcome }}" == "success" || "${{ steps.deploy-new.outcome }}" == "skipped") && "${{ steps.health.outcome }}" == "success" ]]; then
801801
echo "🎉 **DEPLOYMENT SUCCESSFUL**"
802802
echo "✅ All stacks deployed and healthy"
803803
echo "📋 Deployed stacks: $STACK_LIST"

0 commit comments

Comments
 (0)