🐛 fix: CCM crashes when unable to talk to OAPI

Author: jfbus

cloud-controller-manager/osc/oapi/oapi.go

@@ -14,6 +14,7 @@ import (
 
 	osc "github.com/outscale/osc-sdk-go/v2"
 	"k8s.io/klog/v2"
+	"k8s.io/utils/ptr"
 )
 
 const (
@@ -33,11 +34,11 @@ var (
 
 func (c *OscClient) CheckCredentials(ctx context.Context) error {
 	logger := klog.FromContext(ctx)
-	req := osc.ReadVmsRequest{}
+	req := osc.ReadVmsRequest{DryRun: ptr.To(true)}
 	logger.V(4).Info("Check credentials", "OAPI", "ReadVms")
 	_, httpRes, err := c.api.VmApi.ReadVms(c.WithAuth(ctx)).ReadVmsRequest(req).Execute()
 	switch {
-	case err == nil || httpRes.StatusCode == http.StatusTooManyRequests:
+	case err == nil || (httpRes != nil && httpRes.StatusCode == http.StatusTooManyRequests):
 		return nil
 	case httpRes == nil:
 		logger.V(3).Error(err, "OAPI error", "OAPI", "ReadVms")

cloud-controller-manager/osc/oapi/oapi_test.go

@@ -21,4 +21,12 @@ func TestCheckCredentials(t *testing.T) {
 		err = api.OAPI().CheckCredentials(t.Context())
 		require.ErrorIs(t, err, oapi.ErrInvalidCredentials)
 	})
+	t.Run("CheckCredentials returns an error in case of a network problem", func(t *testing.T) {
+		t.Setenv("OSC_ACCESS_KEY", "foo")
+		t.Setenv("OSC_SECRET_KEY", "bar")
+		api, err := oapi.NewClient("foo")
+		require.NoError(t, err)
+		err = api.OAPI().CheckCredentials(t.Context())
+		require.Error(t, err)
+	})
 }