Skip to content

ui-lib: most peerdeps should be a dependency #2624

@jschuler

Description

@jschuler

in OCM (currently trying to switch to npm):

ERROR in ./node_modules/@openshift-assisted/ui-lib/build/cjs/common/components/ui/formik/LabelField.js 8:50-76

Module not found: Error: Can't resolve 'react-tagsinput' in '/container_workspace/node_modules/@openshift-assisted/ui-lib/build/cjs/common/components/ui/formik'

Same for @sentry/browser, 'axios', monaco-editor, etc...

Looking at the package.json file

"peerDependencies": {
    "@reduxjs/toolkit": "^1.9.1",
    "@sentry/browser": "^5.9 || ^6",
    "axios": ">=0.22.0 <1.0.0",
    "i18next": "^20.4 || ^21",
    "monaco-editor": "0.45.0",
    "react": "^17 || ^18",
    "react-dom": "^17 || ^18",
    "react-i18next": ">11.7.3",
    "react-monaco-editor": "^0.55.0",
    "react-redux": "^8.0.5",
    "react-router-dom": "^5.3.0",
    "react-tagsinput": "^3.20",
    "redux": "^4",
    "uuid": "^8.1",
    "yup": "^1.4.0"
  },

Most of these should be dependencies apart from react and react-dom

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions