feat!: Drop support for the legacy video upload page.

The legacy video uploads page in Studio has been replaced with a new
view in the Authoring MFE.  This change removes the now unused
JS/CSS/HTML/Python related to the old video page.

This work is part of #36108

BREAKING CHANGE: The `contentstore.new_studio_mfe.use_new_video_uploads_page`
waffle flag is no longer respected. The code operates as if this is set to True.

Author: feanil

cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py

@@ -111,9 +111,14 @@ def get_use_new_files_uploads_page(self, obj):
     def get_use_new_video_uploads_page(self, obj):
         """
         Method to get the use_new_video_uploads_page switch
+
+        This used to be based on a waffle flag but the flag is being removed so we
+        default it to true for now until we can remove the need for it from the consumers
+        of this serializer and the related APIs.
+
+        See https://github.com/openedx/edx-platform/issues/37497
         """
-        course_key = self.get_course_key()
-        return toggles.use_new_video_uploads_page(course_key)
+        return True
 
     def get_use_new_course_outline_page(self, obj):
         """

cms/djangoapps/contentstore/toggles.py

@@ -313,26 +313,6 @@ def use_new_export_page(course_key):
     return not LEGACY_STUDIO_EXPORT.is_enabled(course_key)
 
 
-# .. toggle_name: contentstore.new_studio_mfe.use_new_video_uploads_page
-# .. toggle_implementation: CourseWaffleFlag
-# .. toggle_default: False
-# .. toggle_description: This flag enables the use of the new studio video uploads page mfe
-# .. toggle_use_cases: temporary
-# .. toggle_creation_date: 2023-5-15
-# .. toggle_target_removal_date: 2023-8-31
-# .. toggle_tickets: TNL-10619
-# .. toggle_warning:
-ENABLE_NEW_STUDIO_VIDEO_UPLOADS_PAGE = CourseWaffleFlag(
-    f'{CONTENTSTORE_NAMESPACE}.new_studio_mfe.use_new_video_uploads_page', __name__)
-
-
-def use_new_video_uploads_page(course_key):
-    """
-    Returns a boolean if new studio video uploads mfe is enabled
-    """
-    return ENABLE_NEW_STUDIO_VIDEO_UPLOADS_PAGE.is_enabled(course_key)
-
-
 # .. toggle_name: legacy_studio.course_outline
 # .. toggle_implementation: WaffleFlag
 # .. toggle_default: False

cms/djangoapps/contentstore/utils.py

@@ -53,7 +53,6 @@
     use_new_textbooks_page,
     use_new_unit_page,
     use_new_updates_page,
-    use_new_video_uploads_page,
 )
 from cms.djangoapps.models.settings.course_grading import CourseGradingModel
 from cms.djangoapps.models.settings.course_metadata import CourseMetadata
@@ -427,11 +426,10 @@ def get_video_uploads_url(course_locator) -> str:
     Gets course authoring microfrontend URL for files and uploads page view.
     """
     video_uploads_url = None
-    if use_new_video_uploads_page(course_locator):
-        mfe_base_url = get_course_authoring_url(course_locator)
-        course_mfe_url = f'{mfe_base_url}/course/{course_locator}/videos/'
-        if mfe_base_url:
-            video_uploads_url = course_mfe_url
+    mfe_base_url = get_course_authoring_url(course_locator)
+    course_mfe_url = f'{mfe_base_url}/course/{course_locator}/videos/'
+    if mfe_base_url:
+        video_uploads_url = course_mfe_url
     return video_uploads_url
 
 

cms/djangoapps/contentstore/video_storage_handlers.py

@@ -51,7 +51,6 @@
 from tempfile import NamedTemporaryFile, mkdtemp
 from wsgiref.util import FileWrapper
 
-from common.djangoapps.edxmako.shortcuts import render_to_response
 from common.djangoapps.util.json_request import JsonResponse
 from openedx.core.djangoapps.video_config.models import VideoTranscriptEnabledFlag
 from openedx.core.djangoapps.video_config.toggles import PUBLIC_VIDEO_SHARE
@@ -63,8 +62,8 @@
 from xmodule.modulestore.django import modulestore  # lint-amnesty, pylint: disable=wrong-import-order
 
 from .models import VideoUploadConfig
-from .toggles import use_new_video_uploads_page, use_mock_video_uploads
-from .utils import get_video_uploads_url, get_course_videos_context
+from .toggles import use_mock_video_uploads
+from .utils import get_video_uploads_url
 from .video_utils import validate_video_image
 from .views.course import get_course_and_check_access
 
@@ -741,13 +740,7 @@ def videos_index_html(course, pagination_conf=None):
     """
     Returns an HTML page to display previous video uploads and allow new ones
     """
-    if use_new_video_uploads_page(course.id):
-        return redirect(get_video_uploads_url(course.id))
-    context = get_course_videos_context(
-        course,
-        pagination_conf,
-    )
-    return render_to_response('videos_index.html', context)
+    return redirect(get_video_uploads_url(course.id))
 
 
 def videos_index_json(course):

cms/static/cms/js/spec/main.js

@@ -252,12 +252,8 @@
         'js/spec/utils/drag_and_drop_spec',
         'js/spec/utils/handle_iframe_binding_spec',
         'js/spec/utils/module_spec',
-        'js/spec/views/active_video_upload_list_spec',
-        'js/spec/views/previous_video_upload_spec',
         'js/spec/views/video_thumbnail_spec',
-        'js/spec/views/course_video_settings_spec',
         'js/spec/views/video_transcripts_spec',
-        'js/spec/views/previous_video_upload_list_spec',
         'js/spec/views/assets_spec',
         'js/spec/views/baseview_spec',
         'js/spec/views/paged_container_spec',