Merge pull request #75 from openaddresses/check-null-field-names

Move filter to the right spot when calculating field names to request

Author: iandees

openaddr/cache.py

@@ -360,7 +360,7 @@ def field_names_to_request(cls, source_config):
 
         if fields:
             # Remove any blank or None values
-            return list(filter(None, sorted(fields)))
+            return list(sorted(filter(None, fields)))
         else:
             return None
 

openaddr/tests/cache.py

@@ -339,12 +339,13 @@ def test_field_names_to_request(self):
                             "function": "constant",
                             "value": "123",
                         },
+                        "region": "StateColumn",
                     }
                 }]
             }
         }), "addresses", "default")
         fields11 = EsriRestDownloadTask.field_names_to_request(conform11)
-        self.assertEqual(fields11, ['Number', 'Street'])
+        self.assertEqual(fields11, ['Number', 'StateColumn', 'Street'])
 
     def test_handle_feature_server_with_lat_lon_in_conform(self):
         '''