fix: panics on tests across engine (#1746)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [ ] reference issue for this pull request: <!-- add URL here -->
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

This diff fixes several instances of panics we see in tests across the
engine repo which went unnoticed in the other diffs.

Author: DecFox

internal/engine/experiment_test.go

@@ -11,12 +11,13 @@ import (
 	"github.com/ooni/probe-cli/v3/internal/experiment/dnscheck"
 	"github.com/ooni/probe-cli/v3/internal/experiment/example"
 	"github.com/ooni/probe-cli/v3/internal/experiment/signal"
+	"github.com/ooni/probe-cli/v3/internal/kvstore"
 	"github.com/ooni/probe-cli/v3/internal/model"
 )
 
 func TestExperimentHonoursSharingDefaults(t *testing.T) {
 	measure := func(info *enginelocate.Results) *model.Measurement {
-		sess := &Session{location: info}
+		sess := &Session{location: info, kvStore: &kvstore.Memory{}}
 		builder, err := sess.NewExperimentBuilder("example")
 		if err != nil {
 			t.Fatal(err)

internal/engine/session_internal_test.go

@@ -337,7 +337,8 @@ func TestNewSessionWithFakeTunnelAndCancelledContext(t *testing.T) {
 func TestSessionNewExperimentBuilder(t *testing.T) {
 	t.Run("for a normal experiment", func(t *testing.T) {
 		sess := &Session{
-			logger: model.DiscardLogger,
+			kvStore: &kvstore.Memory{},
+			logger:  model.DiscardLogger,
 		}
 		builder, err := sess.NewExperimentBuilder("ndt7")
 		if err != nil {

internal/oonirun/experiment_test.go

@@ -128,6 +128,15 @@ func TestExperimentRunWithFailureToSubmitAndShuffle(t *testing.T) {
 
 // This test ensures that we honour InitialOptions then ExtraOptions.
 func TestExperimentSetOptions(t *testing.T) {
+	ctx := context.Background()
+	session, err := engine.NewSession(ctx, engine.SessionConfig{
+		Logger:          model.DiscardLogger,
+		SoftwareName:    "ooniprobe-test",
+		SoftwareVersion: "1.0",
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	// create the Experiment we're using for this test
 	exp := &Experiment{
@@ -140,7 +149,7 @@ func TestExperimentSetOptions(t *testing.T) {
 		// TODO(bassosimone): A zero-value session works here. The proper change
 		// however would be to write a engine.NewExperimentBuilder factory that takes
 		// as input an interface for the session. This would help testing.
-		Session: &engine.Session{},
+		Session: session,
 	}
 
 	// create the experiment builder manually

pkg/oonimkall/taskrunner_test.go

@@ -276,6 +276,9 @@ func TestTaskRunnerRun(t *testing.T) {
 				MockResolverNetworkName: func() string {
 					return "GARR"
 				},
+				MockGeoipDB: func() string {
+					return ""
+				},
 			},
 
 			Loader: &mocks.ExperimentTargetLoader{