Skip to content

Commit e4e72d2

Browse files
Remove deprecation warning from IDTokenVerifier
1 parent b71735c commit e4e72d2

File tree

3 files changed

+34
-12
lines changed

3 files changed

+34
-12
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ python:
88
install:
99
- pip install -U -r requirements.txt
1010
- pip install -U -r test_requirements.txt
11+
- pip install -U flake8
1112

1213
script:
1314
- echo "Running tests in job stages..."
@@ -28,4 +29,4 @@ jobs:
2829
name: "Flake8 Check"
2930
script:
3031
- echo "Code Style check..."
31-
- "flake8 okta_jwt_verifier/"
32+
- "flake8 --extend-ignore=E501 okta_jwt_verifier/"

okta_jwt_verifier/jwt_verifier.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def __init__(self,
278278
proxy=proxy)
279279

280280

281-
class AccessTokenVerifier(BaseJWTVerifier):
281+
class AccessTokenVerifier():
282282
def __init__(self,
283283
issuer=None,
284284
audience='api://default',
@@ -339,16 +339,16 @@ def __init__(self,
339339
leeway: int, amount of time to expand the window for token expiration (to work around clock skew)
340340
cache_jwks: bool, optional
341341
"""
342-
self._jwt_verifier = JWTVerifier(issuer,
343-
client_id,
344-
audience,
345-
request_executor,
346-
max_retries,
347-
request_timeout,
348-
max_requests,
349-
leeway,
350-
cache_jwks,
351-
proxy)
342+
self._jwt_verifier = BaseJWTVerifier(issuer,
343+
client_id,
344+
audience,
345+
request_executor,
346+
max_retries,
347+
request_timeout,
348+
max_requests,
349+
leeway,
350+
cache_jwks,
351+
proxy)
352352

353353
async def verify(self, token, claims_to_verify=('iss', 'exp'), nonce=None):
354354
await self._jwt_verifier.verify_id_token(token, claims_to_verify, nonce)

tests/unit/test_jwt_verifier.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,3 +278,24 @@ def test_verify_expiration(mocker):
278278
def test_deprecation_warning():
279279
with pytest.warns(DeprecationWarning):
280280
jwt_verifier = JWTVerifier(issuer='https://test_issuer.com')
281+
282+
283+
def test_no_deprecation_warning():
284+
# there is no nice way to check it, so use workaround with try/except/else
285+
try:
286+
with pytest.warns(DeprecationWarning):
287+
jwt_verifier = AccessTokenVerifier(issuer='https://test_issuer.com')
288+
except:
289+
# this means "no deprecation warning"
290+
assert True
291+
else:
292+
assert False
293+
294+
try:
295+
with pytest.warns(DeprecationWarning):
296+
jwt_verifier = IDTokenVerifier(issuer='https://test_issuer.com')
297+
except:
298+
# this means "no deprecation warning"
299+
assert True
300+
else:
301+
assert False

0 commit comments

Comments
 (0)