Skip to content

Commit d0968c5

Browse files
committed
Updates to use the autoconfig in java-metrics repo
1 parent 3c594ff commit d0968c5

File tree

9 files changed

+68
-94
lines changed

9 files changed

+68
-94
lines changed

simple/accountmgr/pom.xml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
<java.version>1.8</java.version>
2525

2626
<jaeger.version>0.20.6</jaeger.version>
27-
<java-metrics.version>0.1.1</java-metrics.version>
27+
<java-metrics.version>0.1.3</java-metrics.version>
2828
<prometheus.version>0.0.23</prometheus.version>
29-
<opentracing-contrib-springweb.version>0.0.6</opentracing-contrib-springweb.version>
29+
<opentracing-contrib-springweb.version>0.0.7</opentracing-contrib-springweb.version>
3030
</properties>
3131

3232
<dependencies>
@@ -40,43 +40,34 @@
4040
<artifactId>opentracing-spring-web-autoconfigure</artifactId>
4141
<version>${opentracing-contrib-springweb.version}</version>
4242
</dependency>
43+
<dependency>
44+
<groupId>io.opentracing.contrib</groupId>
45+
<artifactId>opentracing-metrics-prometheus-spring-autoconfigure</artifactId>
46+
<version>${java-metrics.version}</version>
47+
</dependency>
4348

4449
<dependency>
4550
<groupId>com.uber.jaeger</groupId>
4651
<artifactId>jaeger-tracerresolver</artifactId>
4752
<version>${jaeger.version}</version>
4853
</dependency>
4954

50-
<!-- Hotspot JVM metrics -->
5155
<dependency>
5256
<groupId>io.prometheus</groupId>
5357
<artifactId>simpleclient_hotspot</artifactId>
5458
<version>${prometheus.version}</version>
5559
</dependency>
56-
<!-- Exposition servlet -->
5760
<dependency>
5861
<groupId>io.prometheus</groupId>
5962
<artifactId>simpleclient_servlet</artifactId>
6063
<version>${prometheus.version}</version>
6164
</dependency>
62-
<!-- The client -->
6365
<dependency>
6466
<groupId>io.prometheus</groupId>
6567
<artifactId>simpleclient</artifactId>
6668
<version>${prometheus.version}</version>
6769
</dependency>
6870

69-
<dependency>
70-
<groupId>io.opentracing.contrib</groupId>
71-
<artifactId>opentracing-metrics</artifactId>
72-
<version>${java-metrics.version}</version>
73-
</dependency>
74-
<dependency>
75-
<groupId>io.opentracing.contrib</groupId>
76-
<artifactId>opentracing-metrics-prometheus</artifactId>
77-
<version>${java-metrics.version}</version>
78-
</dependency>
79-
8071
<dependency>
8172
<groupId>org.springframework.boot</groupId>
8273
<artifactId>spring-boot-starter-test</artifactId>
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
package com.example.accountmgr;
2+
3+
import org.springframework.context.annotation.Bean;
4+
5+
import io.opentracing.contrib.metrics.MetricLabel;
6+
import io.opentracing.contrib.metrics.label.BaggageMetricLabel;
7+
import io.opentracing.contrib.metrics.label.ConstMetricLabel;
8+
9+
import org.springframework.context.annotation.Configuration;
10+
11+
@Configuration
12+
public class MetricsConfiguration {
13+
14+
@Bean
15+
public MetricLabel transactionLabel() {
16+
return new BaggageMetricLabel("transaction", "n/a");
17+
}
18+
19+
@Bean
20+
public MetricLabel versionLabel() {
21+
return new ConstMetricLabel("version", System.getenv("VERSION"));
22+
}
23+
24+
}

simple/accountmgr/src/main/java/com/example/accountmgr/PrometheusConfiguration.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

simple/accountmgr/src/main/java/com/example/accountmgr/TracerConfiguration.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.example.accountmgr;
22

33
import org.springframework.context.annotation.Bean;
4-
import io.opentracing.contrib.metrics.prometheus.*;
54
import java.util.regex.Pattern;
65

76
import org.springframework.context.annotation.Configuration;
@@ -11,12 +10,7 @@ public class TracerConfiguration implements javax.servlet.ServletContextListener
1110

1211
@Bean
1312
public io.opentracing.Tracer tracer() {
14-
return io.opentracing.contrib.metrics.Metrics.decorate(
15-
io.opentracing.contrib.tracerresolver.TracerResolver.resolveTracer(),
16-
PrometheusMetricsReporter.newMetricsReporter()
17-
.withBaggageLabel("transaction","n/a")
18-
.withConstLabel("version", System.getenv("VERSION"))
19-
.build());
13+
return io.opentracing.contrib.tracerresolver.TracerResolver.resolveTracer();
2014
}
2115

2216
@Override

simple/ordermgr/pom.xml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
<jaeger.version>0.20.6</jaeger.version>
2727
<java-metrics.version>0.1.1</java-metrics.version>
2828
<prometheus.version>0.0.23</prometheus.version>
29-
<opentracing-contrib-springweb.version>0.0.6</opentracing-contrib-springweb.version>
29+
<opentracing-contrib-springweb.version>0.0.7</opentracing-contrib-springweb.version>
30+
<version.opentracing.contrib.opentracing-metrics>0.1.3</version.opentracing.contrib.opentracing-metrics>
3031
</properties>
3132

3233
<dependencies>
@@ -40,6 +41,11 @@
4041
<artifactId>opentracing-spring-web-autoconfigure</artifactId>
4142
<version>${opentracing-contrib-springweb.version}</version>
4243
</dependency>
44+
<dependency>
45+
<groupId>io.opentracing.contrib</groupId>
46+
<artifactId>opentracing-metrics-prometheus-spring-autoconfigure</artifactId>
47+
<version>${version.opentracing.contrib.opentracing-metrics}</version>
48+
</dependency>
4349

4450
<dependency>
4551
<groupId>com.uber.jaeger</groupId>
@@ -66,17 +72,6 @@
6672
<version>${prometheus.version}</version>
6773
</dependency>
6874

69-
<dependency>
70-
<groupId>io.opentracing.contrib</groupId>
71-
<artifactId>opentracing-metrics</artifactId>
72-
<version>${java-metrics.version}</version>
73-
</dependency>
74-
<dependency>
75-
<groupId>io.opentracing.contrib</groupId>
76-
<artifactId>opentracing-metrics-prometheus</artifactId>
77-
<version>${java-metrics.version}</version>
78-
</dependency>
79-
8075
<dependency>
8176
<groupId>org.springframework.boot</groupId>
8277
<artifactId>spring-boot-starter-test</artifactId>
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
package com.example.ordermgr;
2+
3+
import org.springframework.context.annotation.Bean;
4+
5+
import io.opentracing.contrib.metrics.MetricLabel;
6+
import io.opentracing.contrib.metrics.label.BaggageMetricLabel;
7+
import io.opentracing.contrib.metrics.label.ConstMetricLabel;
8+
9+
import org.springframework.context.annotation.Configuration;
10+
11+
@Configuration
12+
public class MetricsConfiguration {
13+
14+
@Bean
15+
public MetricLabel transactionLabel() {
16+
return new BaggageMetricLabel("transaction", "n/a");
17+
}
18+
19+
@Bean
20+
public MetricLabel versionLabel() {
21+
return new ConstMetricLabel("version", System.getenv("VERSION"));
22+
}
23+
24+
}

simple/ordermgr/src/main/java/com/example/ordermgr/PrometheusConfiguration.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

simple/ordermgr/src/main/java/com/example/ordermgr/TracerConfiguration.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.example.ordermgr;
22

33
import org.springframework.context.annotation.Bean;
4-
import io.opentracing.contrib.metrics.prometheus.*;
54
import java.util.regex.Pattern;
65

76
import org.springframework.context.annotation.Configuration;
@@ -11,12 +10,7 @@ public class TracerConfiguration implements javax.servlet.ServletContextListener
1110

1211
@Bean
1312
public io.opentracing.Tracer tracer() {
14-
return io.opentracing.contrib.metrics.Metrics.decorate(
15-
io.opentracing.contrib.tracerresolver.TracerResolver.resolveTracer(),
16-
PrometheusMetricsReporter.newMetricsReporter()
17-
.withBaggageLabel("transaction","n/a")
18-
.withConstLabel("version", System.getenv("VERSION"))
19-
.build());
13+
return io.opentracing.contrib.tracerresolver.TracerResolver.resolveTracer();
2014
}
2115

2216
@Override

simple/services-kubernetes.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ spec:
3030
value: "version=${VERSION}"
3131
- name: ACCOUNTMGR_URL
3232
value: "http://accountmgr:8080"
33+
- name: OPENTRACING_METRICS_EXPORTER_HTTP_PATH
34+
value: "/metrics"
3335
---
3436
kind: Service
3537
apiVersion: v1
@@ -90,6 +92,8 @@ spec:
9092
value: "true"
9193
- name: JAEGER_TAGS
9294
value: "version=${VERSION}"
95+
- name: OPENTRACING_METRICS_EXPORTER_HTTP_PATH
96+
value: "/metrics"
9397
---
9498
kind: Service
9599
apiVersion: v1

0 commit comments

Comments
 (0)