Skip to content

Commit 300ca41

Browse files
authored
- Upgrade to njre v1.4.0 (#95)
- Fix issue when package called from ES Module by using njre installPath option
1 parent 28b80f5 commit 300ca41

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
## Unreleased
44

5+
## [4.1.1] 2024-08-30
6+
7+
- Upgrade to njre v1.4.0
8+
- Fix issue when package called from ES Module by using njre installPath option
9+
510
## [4.1.0] 2024-08-20
611

712
- Upgrade to MegaLinter v8

lib/java-caller.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,11 +274,8 @@ class JavaCaller {
274274

275275
// Install appropriate java version using njre
276276
const njre = require("njre");
277-
const njreOptions = { type: javaTypeToInstall };
278-
const prevRequireMainFilename = require.main.filename; // hack require.main.filename to njre installs java where we want
279-
require.main.filename = packageJson;
277+
const njreOptions = { type: javaTypeToInstall, installPath: packageJson };
280278
const installDir = await njre.install(javaVersionToInstall, njreOptions);
281-
require.main.filename = prevRequireMainFilename; // unhack require.main.filename
282279
console.log(`Installed Java ${javaTypeToInstall} ${javaVersionToInstall} in ${installDir}...`);
283280

284281
// Call again this method: now matching java version will be found :)

package-lock.json

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"dependencies": {
3838
"debug": "^4.3.4",
3939
"fs-extra": "^11.1.1",
40-
"njre": "^1.2.1",
40+
"njre": "^1.4.0",
4141
"semver": "^7.5.4"
4242
},
4343
"devDependencies": {

0 commit comments

Comments
 (0)