Submission - JermyTan

[JermyTan]

Submission Details

Type of Submission:

• 3 Pull requests
• Self-initiated open-source project

Link to Pull Requests:

Link to open-source project:
Repo: https://github.com/JermyTan/giffindor
Website: https://giffindor.jermytan.com/

Additional information (optional):

• Uses Giphy API to retrieve GIFs information
• Web app supports infinite scrolling and loading of gifs
• Performance is optimised with react virtualized to prevent DOM overload

[chaitanyabaranwal]

Hey Jeremy, thanks for your submission, it looks quite good! If I have to nitpick, you mention in the documentation that we need to email someone to get the keys.js file. However, it would be easier for someone contributing to your project to get the keys themselves. If possible, could you add a section in your documentation on how contributors can go about getting a keys.js file by themselves?

[JermyTan]

Thanks for pointing it out. I've added the instructions to generate the keys.js file in the README.

[chrisgzf]

Hello @JermyTan Mr CS2040S TA, this a cool project! We like how you made use of multiple readily available resources like the GIPHY API and Firebase to come up with a fun and interesting project. Thanks for sharing your work and your OpenHack submission is now accepted!

Please visit https://openhack.nushackers.org/congrats and fill up the form so that we can capture your details for the prizes.

We hope you had fun working on the challenge and we hope you will continue making open-source contributions, even outside of the event! 😃

[JermyTan]

Hihi @chrisgzf, glad u like it 👍🏻.