netmap: don't panic in Price and Capacity methods (#747)

Author: cthulhu-rider

netmap/node_info.go

@@ -230,19 +230,14 @@ func (x *NodeInfo) SetPrice(price uint64) {
 	x.setNumericAttribute(attrPrice, price)
 }
 
-// Price returns price set using SetPrice.
+// Price returns price stored in the Price node attribute.
 //
-// Zero NodeInfo has zero price.
+// Invalid (non-numeric, not valid for returned type) or missing attribute
+// yields zero in return value.
+//
+// See [NodeInfo.SetPrice] also.
 func (x NodeInfo) Price() uint64 {
-	val := x.Attribute(attrPrice)
-	if val == "" {
-		return 0
-	}
-
-	price, err := strconv.ParseUint(val, 10, 64)
-	if err != nil {
-		panic(fmt.Sprintf("unexpected price parsing error %s: %v", val, err))
-	}
+	price, _ := strconv.ParseUint(x.Attribute(attrPrice), 10, 64)
 
 	return price
 }
@@ -259,19 +254,14 @@ func (x *NodeInfo) SetVersion(version string) {
 	x.SetAttribute(attrVersion, version)
 }
 
-// Capacity returns capacity set using SetCapacity.
+// Capacity returns capacity (GB) stored in the Capacity node attribute.
 //
-// Zero NodeInfo has zero capacity.
+// Invalid (non-numeric, not valid for returned type) or missing attribute
+// yields zero in return value.
+//
+// See [NodeInfo.SetCapacity] also.
 func (x NodeInfo) Capacity() uint64 {
-	val := x.Attribute(attrCapacity)
-	if val == "" {
-		return 0
-	}
-
-	capacity, err := strconv.ParseUint(val, 10, 64)
-	if err != nil {
-		panic(fmt.Sprintf("unexpected capacity parsing error %s: %v", val, err))
-	}
+	capacity, _ := strconv.ParseUint(x.Attribute(attrCapacity), 10, 64)
 
 	return capacity
 }