Skip to content

{knitr} should be suggests not import #142

@kellijohnson-NOAA

Description

@kellijohnson-NOAA

{knitr} is not used in any of the functions, only in building the vignettes so I think it should be a suggested package in the DESCRIPTION rather than a required package. I found this out when I recently installed {stockplotr} in a codespace and it took forever. There are a lot of packages in {asar} that take a long time to install plus the needed packages from this package.

knitr,

Sidenote

I see one function that is in {asar} that is actually used within {stockplotr}. I know that we talked about this yesterday regarding {asar} vs. {stockplotr} for where things should be but I think that people are going to end up interacting more with {stockplotr} than they will with {asar} so one might think about rearranging some dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions