fix: preserve sourcemap mappings for chunks containing user code (#4031)

Author: logaretm

src/build/plugins/sourcemap-min.ts

@@ -19,7 +19,7 @@ export function sourcemapMinify() {
         // Remove x_google_ignoreList
         delete sourcemap.x_google_ignoreList;
 
-        if ((sourcemap.sources || []).some((s) => s.includes("node_modules"))) {
+        if ((sourcemap.sources || []).every((s) => s.includes("node_modules"))) {
           sourcemap.mappings = ""; // required key
         }
 

test/unit/sourcemap-min.test.ts

@@ -0,0 +1,112 @@
+import { describe, expect, it } from "vitest";
+import { sourcemapMinify } from "../../src/build/plugins/sourcemap-min.ts";
+
+type BundleAsset = { type: "asset"; source: string };
+
+function createSourcemapAsset(sourcemap: {
+  sources?: string[];
+  sourcesContent?: string[];
+  mappings?: string;
+  x_google_ignoreList?: number[];
+}): BundleAsset {
+  return {
+    type: "asset",
+    source: JSON.stringify({
+      version: 3,
+      sources: [],
+      mappings: "AAAA,CAAC",
+      ...sourcemap,
+    }),
+  };
+}
+
+function runPlugin(bundle: Record<string, BundleAsset>) {
+  const plugin = sourcemapMinify();
+  (plugin.generateBundle as Function).call(null, {}, bundle);
+  const results: Record<string, ReturnType<typeof JSON.parse>> = {};
+  for (const [key, asset] of Object.entries(bundle)) {
+    if (key.endsWith(".map")) {
+      results[key] = JSON.parse(asset.source);
+    }
+  }
+  return results;
+}
+
+describe("sourcemapMinify", () => {
+  it("removes sourcesContent from all sourcemaps", () => {
+    const bundle = {
+      "index.mjs.map": createSourcemapAsset({
+        sources: ["src/index.ts"],
+        sourcesContent: ["export default 42;"],
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["index.mjs.map"].sourcesContent).toBeUndefined();
+  });
+
+  it("removes x_google_ignoreList from all sourcemaps", () => {
+    const bundle = {
+      "index.mjs.map": createSourcemapAsset({
+        sources: ["src/index.ts"],
+        x_google_ignoreList: [0],
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["index.mjs.map"].x_google_ignoreList).toBeUndefined();
+  });
+
+  it("wipes mappings for pure library chunks", () => {
+    const bundle = {
+      "_libs/express.mjs.map": createSourcemapAsset({
+        sources: [
+          "../../node_modules/express/index.js",
+          "../../node_modules/express/lib/router.js",
+        ],
+        mappings: "AAAA,CAAC",
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["_libs/express.mjs.map"].mappings).toBe("");
+  });
+
+  it("preserves mappings for pure user code chunks", () => {
+    const bundle = {
+      "_routes/api/hello.mjs.map": createSourcemapAsset({
+        sources: ["src/routes/api/hello.ts"],
+        mappings: "AAAA,CAAC",
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["_routes/api/hello.mjs.map"].mappings).toBe("AAAA,CAAC");
+  });
+
+  it("preserves mappings when library is hoisted into user chunk", () => {
+    const bundle = {
+      "_routes/api/hello.mjs.map": createSourcemapAsset({
+        sources: ["src/routes/api/hello.ts", "../../node_modules/some-lib/index.js"],
+        mappings: "AAAA,CAAC",
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["_routes/api/hello.mjs.map"].mappings).toBe("AAAA,CAAC");
+  });
+
+  it("skips non-sourcemap files", () => {
+    const bundle = {
+      "index.mjs": { type: "asset" as const, source: "console.log(42)" },
+    };
+    runPlugin(bundle as any);
+    expect(bundle["index.mjs"].source).toBe("console.log(42)");
+  });
+
+  it("handles empty sources array", () => {
+    const bundle = {
+      "chunk.mjs.map": createSourcemapAsset({
+        sources: [],
+        mappings: "AAAA,CAAC",
+      }),
+    };
+    const results = runPlugin(bundle);
+    expect(results["chunk.mjs.map"].mappings).toBe("");
+  });
+});