♻️ Renamed as_array to to_a

cimnine · cimnine · commit e2940aec69be · 2017-11-01T10:38:09.000+01:00
.. which is more common.
diff --git a/lib/netbox_client_ruby/entities.rb b/lib/netbox_client_ruby/entities.rb
@@ -120,7 +120,7 @@ def [](index)
       as_entity raw_data_array[index]
     end
 
-    def as_array
+    def to_a
       raw_data_array.map { |raw_entity| as_entity raw_entity }
     end
 
diff --git a/spec/netbox_client_ruby/api/dcim/device_roles_spec.rb b/spec/netbox_client_ruby/api/dcim/device_roles_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/device_types_spec.rb b/spec/netbox_client_ruby/api/dcim/device_types_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/devices_spec.rb b/spec/netbox_client_ruby/api/dcim/devices_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/interfaces_spec.rb b/spec/netbox_client_ruby/api/dcim/interfaces_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/inventory_items_spec.rb b/spec/netbox_client_ruby/api/dcim/inventory_items_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/manufacturers_spec.rb b/spec/netbox_client_ruby/api/dcim/manufacturers_spec.rb
@@ -42,11 +42,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be 2
+      expect(subject.to_a.length).to be 2
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a NetboxClientRuby::DCIM::Region
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/platforms_spec.rb b/spec/netbox_client_ruby/api/dcim/platforms_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/power_outlets_spec.rb b/spec/netbox_client_ruby/api/dcim/power_outlets_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/power_ports_spec.rb b/spec/netbox_client_ruby/api/dcim/power_ports_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/rack_groups_spec.rb b/spec/netbox_client_ruby/api/dcim/rack_groups_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/racks_spec.rb b/spec/netbox_client_ruby/api/dcim/racks_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/regions_spec.rb b/spec/netbox_client_ruby/api/dcim/regions_spec.rb
@@ -42,11 +42,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be 2
+      expect(subject.to_a.length).to be 2
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a NetboxClientRuby::DCIM::Region
       end
     end
diff --git a/spec/netbox_client_ruby/api/dcim/sites_spec.rb b/spec/netbox_client_ruby/api/dcim/sites_spec.rb
@@ -70,11 +70,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be 2
+      expect(subject.to_a.length).to be 2
     end
 
     it 'returns Site instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a NetboxClientRuby::DCIM::Site
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/aggregates_spec.rb b/spec/netbox_client_ruby/api/ipam/aggregates_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/ip_addresses_spec.rb b/spec/netbox_client_ruby/api/ipam/ip_addresses_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/prefixes_spec.rb b/spec/netbox_client_ruby/api/ipam/prefixes_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/rirs_spec.rb b/spec/netbox_client_ruby/api/ipam/rirs_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/roles_spec.rb b/spec/netbox_client_ruby/api/ipam/roles_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/vlan_groups_spec.rb b/spec/netbox_client_ruby/api/ipam/vlan_groups_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/vlans_spec.rb b/spec/netbox_client_ruby/api/ipam/vlans_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/ipam/vrfs_spec.rb b/spec/netbox_client_ruby/api/ipam/vrfs_spec.rb
@@ -45,11 +45,11 @@
 
   describe '#as_array' do
     it 'return the correct amount' do
-      expect(subject.as_array.length).to be expected_length
+      expect(subject.to_a.length).to be expected_length
     end
 
     it 'returns single instances' do
-      subject.as_array.each do |element|
+      subject.to_a.each do |element|
         expect(element).to be_a expected_singular_type
       end
     end
diff --git a/spec/netbox_client_ruby/api/secrets/secret_roles_spec.rb b/spec/netbox_client_ruby/api/secrets/secret_roles_spec.rb
@@ -44,11 +44,11 @@ module Secrets
 
       describe '#as_array' do
         it 'return the correct amount' do
-          expect(subject.as_array.length).to be 2
+          expect(subject.to_a.length).to be 2
         end
 
         it 'returns single instances' do
-          subject.as_array.each do |element|
+          subject.to_a.each do |element|
             expect(element).to be_a SecretRole
           end
         end
diff --git a/spec/netbox_client_ruby/api/secrets/secrets_spec.rb b/spec/netbox_client_ruby/api/secrets/secrets_spec.rb
@@ -44,11 +44,11 @@ module Secrets
 
       describe '#as_array' do
         it 'return the correct amount' do
-          expect(subject.as_array.length).to be 1
+          expect(subject.to_a.length).to be 1
         end
 
         it 'returns single instances' do
-          subject.as_array.each do |element|
+          subject.to_a.each do |element|
             expect(element).to be_a Secret
           end
         end
diff --git a/spec/netbox_client_ruby/api/tenancy/tenants_groups_spec.rb b/spec/netbox_client_ruby/api/tenancy/tenants_groups_spec.rb
@@ -47,11 +47,11 @@ module Tenancy
 
       describe '#as_array' do
         it 'return the correct amount' do
-          expect(subject.as_array.length).to be expected_number_of_items
+          expect(subject.to_a.length).to be expected_number_of_items
         end
 
         it 'returns single instances' do
-          subject.as_array.each do |element|
+          subject.to_a.each do |element|
             expect(element).to be_a expected_singular_type
           end
         end
diff --git a/spec/netbox_client_ruby/api/tenancy/tenants_spec.rb b/spec/netbox_client_ruby/api/tenancy/tenants_spec.rb
@@ -44,11 +44,11 @@ module Tenancy
 
       describe '#as_array' do
         it 'return the correct amount' do
-          expect(subject.as_array.length).to be 3
+          expect(subject.to_a.length).to be 3
         end
 
         it 'returns single instances' do
-          subject.as_array.each do |element|
+          subject.to_a.each do |element|
             expect(element).to be_a Tenant
           end
         end
diff --git a/spec/netbox_client_ruby/entities_spec.rb b/spec/netbox_client_ruby/entities_spec.rb
@@ -96,22 +96,22 @@ class TestEntities3
     end
   end
 
-  describe '#as_array' do
+  describe '#to_a' do
     it 'returns an Array' do
-      expect(subject.as_array).to be_a Array
-      expect(subject.as_array.length).to be 3
+      expect(subject.to_a).to be_a Array
+      expect(subject.to_a.length).to be 3
     end
 
     it 'returns the entities as array' do
-      subject.as_array.each do |entity|
+      subject.to_a.each do |entity|
         expect(entity).to be_a OpenStruct
         expect(entity).to respond_to :data
         expect(entity.data).to be_a Hash
       end
     end
 
     it 'returns a fresh Array every time' do
-      expect(subject.as_array).to_not be subject.as_array
+      expect(subject.to_a).to_not be subject.to_a
     end
   end
 
@@ -136,7 +136,7 @@ class TestEntities3
 
     describe '#as_array' do
       it 'returns an empty Array' do
-        expect(subject.as_array).to eq []
+        expect(subject.to_a).to eq []
       end
     end
 
