Use event name to determine if approval is required

Author: bogsi17

.github/workflows/data-replication-pipeline.yml

@@ -31,19 +31,11 @@ on:
         description: Git ref to deploy, for example, a tag, branch name or commit SHA
         type: string
         required: true  
-      skip_approval:
-        description: Skip environment approval (auto-approve)
-        type: boolean
-        default: false
 
 permissions: {}
 
 env:
   environment: ${{ inputs.environment }}
-  deployment_type: ${{ inputs.deployment_type }}
-  db_snapshot_arn: ${{ inputs.db_snapshot_arn }}
-  egress_cidr: ${{ inputs.egress_cidr }}
-  take_db_snapshot: ${{ inputs.take_db_snapshot }}
   git_ref_to_deploy: ${{ inputs.git_ref_to_deploy || github.sha }}
   aws_role: ${{ inputs.environment == 'production'
     && 'arn:aws:iam::820242920762:role/GithubDeployDataReplicationInfrastructure'
@@ -148,7 +140,7 @@ jobs:
     name: Notify on approval required
     runs-on: ubuntu-latest
     needs: prepare-deployment
-    if: ${{ inputs.environment == 'production' && inputs.skip_approval == 'false' }}
+    if: ${{ inputs.environment == 'production' && github.event_name == 'workflow_dispatch' }}
     steps:
       - name: Notify pending approval
         if: inputs.environment == 'production'
@@ -174,7 +166,7 @@ jobs:
     name: Wait for approval if required
     runs-on: ubuntu-latest
     needs: prepare-deployment
-    environment: ${{ inputs.skip_approval && null || inputs.environment }}
+    environment: ${{ github.event_name == 'workflow_dispatch' && inputs.environment || null }}
     steps:
       - run: echo "Proceeding with deployment to $environment environment"
 

.github/workflows/refresh-data-replication.yml

@@ -47,10 +47,6 @@ on:
         description: Take a new DB snapshot before creating the environment
         type: boolean
         default: false
-      skip_approval:
-        description: Skip environment approval (auto-approve)
-        type: boolean
-        default: false
 
 permissions: {}
 
@@ -184,7 +180,7 @@ jobs:
     name: Notify on approval required
     runs-on: ubuntu-latest
     needs: plan
-    if: ${{ inputs.environment == 'production' && inputs.skip_approval == 'false' }}
+    if: ${{ inputs.environment == 'production' && github.event_name == 'workflow_dispatch' }}
     steps:
       - name: Notify pending approval
         if: inputs.environment == 'production'
@@ -210,7 +206,7 @@ jobs:
     name: Terraform apply
     runs-on: ubuntu-latest
     needs: plan
-    environment: ${{ inputs.skip_approval && null || inputs.environment }}
+    environment: ${{ github.event_name == 'workflow_dispatch' && inputs.environment || null }}
     permissions:
       id-token: write
     steps:

.github/workflows/scheduled-data-replication-refresh.yml

@@ -23,7 +23,6 @@ jobs:
           "52.178.45.139/32" # GIAS
         ]
       take_db_snapshot: false
-      skip_approval: true
   deploy-image:
     name: Deploy image
     needs: refresh-data-replication
@@ -33,4 +32,3 @@ jobs:
     with:
       environment: production
       git_ref_to_deploy: main
-      skip_approval: true