fix: Small fixes to custom element classes; Increment workflow to Node.js 24

Author: nfreear

.github/workflows/node.js.yml

@@ -5,7 +5,7 @@ name: Deploy
 on: [push, pull_request]
 # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 env:
-  NODE_VERSION: 20
+  NODE_VERSION: 24
 # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
 permissions:
   contents: read

src/components/MyFeedElement.js

@@ -104,7 +104,7 @@ export class MyFeedElement extends HTMLElement {
     const req = this.#createRequest();
     const resp = await fetch(req);
     if (!resp.ok) {
-      throw new Error(`MyFeedElement (fetch): ${resp.status} ~ ${uri}`);
+      throw new Error(`MyFeedElement (fetch): ${resp.status} ~ ${resp.url}`);
     }
     const data = await resp.json();
 

src/components/MySearchElement.js

@@ -13,7 +13,7 @@ export class MySearchElement extends window.HTMLElement {
   get cx () {
     const CX = this.getAttribute('cx'); // || '001222343498871500969:-u73i2qfu2s';
     console.assert(CX, '"cx" - Required attribute');
-    return CX;
+    return CX || undefined;
   }
 
   get label () { return this.getAttribute('label') || 'Search'; }

src/components/MyYoutubeEmbedElement.js

@@ -1,4 +1,3 @@
-
 const { HTMLElement } = window;
 
 /**
@@ -52,7 +51,6 @@ export class MyYoutubeEmbedElement extends HTMLElement {
   _onYouTubeIframeAPIReady (playerElem) {
     window.onYouTubeIframeAPIReady = () => {
       const { YT } = window;
-      console.debug('onYouTubeIframeAPIReady:', YT.PlayerState, YT);
       this._player = new YT.Player(playerElem, {
         height: this.height,
         width: this.width,
@@ -65,6 +63,8 @@ export class MyYoutubeEmbedElement extends HTMLElement {
           onStateChange: (ev) => this._onPlayerStateChange(ev)
         }
       });
+      console.debug('onYouTubeIframeAPIReady:', this._player, YT.PlayerState, YT);
+      this.dataset.ready = true;
     };
   }
 
@@ -81,6 +81,7 @@ export class MyYoutubeEmbedElement extends HTMLElement {
     // target.setPlaybackRate(2);
     const RATE = target.getPlaybackRate();
     console.debug('onPlayerReady:', RATE, videoId, ev);
+    this.dataset.ready = true;
   }
 
   _onPlayerStateChange (ev) {