fix: resolve detekt and ktlint violations

Signed-off-by: David Leibovych <[email protected]>

Author: ariedov

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

@@ -262,6 +262,11 @@ class ChatActivity :
     SystemMessageInterface,
     CallStartedMessageInterface {
 
+    companion object {
+        private const val NOTIFICATION_LEVEL_ALWAYS = 1
+        private const val NOTIFICATION_LEVEL_NEVER = 3
+    }
+
     var active = false
 
     private lateinit var binding: ActivityChatBinding
@@ -3316,8 +3321,8 @@ class ChatActivity :
             hasSpreedFeatureCapability(spreedCapabilities, SpreedFeatures.THREADS)
 
         val threadNotificationIcon = when (conversationThreadInfo?.attendee?.notificationLevel) {
-            1 -> R.drawable.outline_notifications_active_24
-            3 -> R.drawable.ic_baseline_notifications_off_24
+            NOTIFICATION_LEVEL_ALWAYS -> R.drawable.outline_notifications_active_24
+            NOTIFICATION_LEVEL_NEVER -> R.drawable.ic_baseline_notifications_off_24
             else -> R.drawable.baseline_notifications_24
         }
         threadNotificationItem.icon = ContextCompat.getDrawable(context, threadNotificationIcon)
@@ -3423,7 +3428,7 @@ class ChatActivity :
                                 subtitle = null,
                                 icon = R.drawable.ic_baseline_notifications_off_24,
                                 onClick = {
-                                    setThreadNotificationLevel(3)
+                                    setThreadNotificationLevel(NOTIFICATION_LEVEL_NEVER)
                                 }
                             )
                         )
@@ -4094,7 +4099,7 @@ class ChatActivity :
                             displayName = currentConversation?.displayName ?: ""
                         )
                         showSnackBar(roomToken)
-                    } catch (e: Exception) {
+                    } catch (e: IOException) {
                         Log.w(TAG, "File corresponding to the uri does not exist $shareUri", e)
                         downloadFileToCache(message, false) {
                             uploadFile(

app/src/main/java/com/nextcloud/talk/chat/data/model/ChatMessage.kt

@@ -148,8 +148,7 @@ data class ChatMessage(
         MessageType.SINGLE_NC_GEOLOCATION_MESSAGE,
         MessageType.VOICE_MESSAGE,
         MessageType.POLL_MESSAGE,
-        MessageType.DECK_CARD,
-
+        MessageType.DECK_CARD
     )
 
     fun isDeckCard(): Boolean {

app/src/main/java/com/nextcloud/talk/conversationlist/viewmodels/ConversationsListViewModel.kt

@@ -150,7 +150,7 @@ class ConversationsListViewModel @Inject constructor(
                         followedThreadsExistNew.toString(),
                         ""
                     )
-                } catch (exception: Exception) {
+                } catch (exception: Throwable) {
                     _threadsExistState.value = ThreadsExistUiState.Error(exception)
                 }
             }

app/src/main/java/com/nextcloud/talk/ui/ComposeChatAdapter.kt

@@ -323,7 +323,6 @@ class ComposeChatAdapter(
                     }
 
                     ChatMessage.MessageType.FILE_UPLOAD_MESSAGE -> {
-
                     }
 
                     ChatMessage.MessageType.REGULAR_TEXT_MESSAGE -> {

app/src/main/java/third/parties/fresco/BetterImageSpan.kt

@@ -28,7 +28,7 @@ open class BetterImageSpan @JvmOverloads constructor(
     val drawable: Drawable,
     @param:BetterImageSpanAlignment private val mAlignment: Int = ALIGN_BASELINE
 ) : ReplacementSpan() {
-    @IntDef(*[ALIGN_BASELINE, ALIGN_BOTTOM, ALIGN_CENTER])
+    @IntDef(ALIGN_BASELINE, ALIGN_BOTTOM, ALIGN_CENTER)
     @Retention(AnnotationRetention.SOURCE)
     annotation class BetterImageSpanAlignment