feat(permissions): Update reaction permissions handling and add corresponding error message

Signed-off-by: Florian Ludwig <[email protected]>

Author: luflow

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

@@ -3976,7 +3976,7 @@ class ChatActivity :
 
     override fun onClickReaction(chatMessage: ChatMessage, emoji: String) {
         if (!participantPermissions.hasReactPermission()) {
-            Snackbar.make(binding.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
+            Snackbar.make(binding.root, R.string.reaction_forbidden, Snackbar.LENGTH_LONG).show()
             return
         }
         VibrationUtils.vibrateShort(context)
@@ -3997,7 +3997,7 @@ class ChatActivity :
             roomToken,
             chatMessage,
             conversationUser,
-            participantPermissions.hasChatPermission(),
+            participantPermissions.hasReactPermission(),
             ncApi
         ).show()
     }

app/src/main/java/com/nextcloud/talk/ui/dialog/ShowReactionsDialog.kt

@@ -47,7 +47,7 @@ class ShowReactionsDialog(
     private val roomToken: String,
     private val chatMessage: ChatMessage,
     private val user: User?,
-    private val hasChatPermission: Boolean,
+    private val hasReactPermission: Boolean,
     private val ncApi: NcApi
 ) : BottomSheetDialog(activity),
     ReactionItemClickListener {
@@ -185,7 +185,7 @@ class ShowReactionsDialog(
     }
 
     override fun onClick(reactionItem: ReactionItem) {
-        if (hasChatPermission && reactionItem.reactionVoter.actorId?.equals(user?.userId) == true) {
+        if (hasReactPermission && reactionItem.reactionVoter.actorId?.equals(user?.userId) == true) {
             deleteReaction(chatMessage, reactionItem.reaction!!)
             adapter?.list?.remove(reactionItem)
             dismiss()

app/src/main/java/com/nextcloud/talk/utils/ParticipantPermissions.kt

@@ -76,13 +76,8 @@ class ParticipantPermissions(
             // Server supports separate react permission - check REACT bit
             return hasReactPermission
         }
-        if (CapabilitiesUtil.hasSpreedFeatureCapability(spreedCapabilities, SpreedFeatures.CHAT_PERMISSION)) {
-            // Older server without react-permission capability - fall back to CHAT permission
-            // as that's what controlled reactions before the split
-            return hasChatPermission
-        }
-        // if capability is not available then the spreed version doesn't support to restrict this
-        return true
+        // Older server without react-permission capability - fall back to chat permission
+        return hasChatPermission()
     }
 
     companion object {

app/src/main/res/values/strings.xml

@@ -550,6 +550,7 @@ How to translate with transifex:
     <string name="read_storage_no_permission">Sharing files from storage is not possible without permissions</string>
     <string name="open_in_files_app">Open in Files app</string>
     <string name="send_to_forbidden">You are not allowed to share content to this chat</string>
+    <string name="reaction_forbidden">You are not allowed to add or remove reactions in this conversation</string>
 
     <string name="typing_is_typing">is typing …</string>
     <string name="typing_are_typing">are typing …</string>