diff --git a/lib/Activity/ActivityManager.php b/lib/Activity/ActivityManager.php index c8a16a31d..5d88237ac 100644 --- a/lib/Activity/ActivityManager.php +++ b/lib/Activity/ActivityManager.php @@ -28,10 +28,11 @@ public function __construct( /** * Publish a new-Share Activity + * * @param Form $form The shared form * @param string $shareeId UserId, the form has been shared to */ - public function publishNewShare(Form $form, string $shareeId) { + public function publishNewShare(Form $form, string $shareeId): void { $event = $this->manager->generateEvent(); $event->setApp($this->appName) ->setType(ActivityConstants::TYPE_NEWSHARE) @@ -49,10 +50,11 @@ public function publishNewShare(Form $form, string $shareeId) { /** * Publish a new-GroupShare Activity to each affected user + * * @param Form $form The shared form * @param string $groupId Group the form has been shared to */ - public function publishNewGroupShare(Form $form, string $groupId) { + public function publishNewGroupShare(Form $form, string $groupId): void { $affectedUsers = $this->groupManager->get($groupId)->getUsers(); foreach ($affectedUsers as $user) { @@ -79,7 +81,7 @@ public function publishNewGroupShare(Form $form, string $groupId) { * @param Form $form The shared form * @param string $circleId Circle the form has been shared to */ - public function publishNewCircleShare(Form $form, string $circleId) { + public function publishNewCircleShare(Form $form, string $circleId): void { $users = $this->circlesService->getCircleUsers($circleId); foreach ($users as $user) { @@ -102,10 +104,11 @@ public function publishNewCircleShare(Form $form, string $circleId) { /** * Publish a new-Submission Activity + * * @param Form $form The affected Form * @param string $submitterID ID of the User who submitted the form. Can also be our 'anon-user-'-ID */ - public function publishNewSubmission(Form $form, string $submitterID) { + public function publishNewSubmission(Form $form, string $submitterID): void { $event = $this->manager->generateEvent(); $event->setApp($this->appName) ->setType(ActivityConstants::TYPE_NEWSUBMISSION) @@ -127,7 +130,7 @@ public function publishNewSubmission(Form $form, string $submitterID) { * @param Form $form The affected Form * @param string $submitterID ID of the User who submitted the form. Can also be our 'anon-user-'-ID */ - public function publishNewSharedSubmission(Form $form, int $shareType, string $shareWith, string $submitterID) { + public function publishNewSharedSubmission(Form $form, int $shareType, string $shareWith, string $submitterID): void { $users = []; switch ($shareType) { case IShare::TYPE_USER: diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php index 4072dedc1..d9a827f13 100644 --- a/lib/Controller/ApiController.php +++ b/lib/Controller/ApiController.php @@ -96,6 +96,8 @@ public function __construct( // CORS preflight /** * Handle CORS options request by calling parent function + * + * @return void */ #[ApiRoute(verb: 'OPTIONS', url: '/api/v3/{path}', requirements: ['path' => '.+'])] public function preflightedCors() { @@ -1527,7 +1529,7 @@ public function uploadFiles(int $formId, int $questionId, string $shareHash = '' * @param array $question * @param string[]|array $answerArray */ - private function storeAnswersForQuestion(Form $form, $submissionId, array $question, array $answerArray) { + private function storeAnswersForQuestion(Form $form, $submissionId, array $question, array $answerArray): void { foreach ($answerArray as $answer) { $answerEntity = new Answer(); $answerEntity->setSubmissionId($submissionId); diff --git a/lib/Controller/PageController.php b/lib/Controller/PageController.php index 71b5ebe47..8dc1ae1dc 100644 --- a/lib/Controller/PageController.php +++ b/lib/Controller/PageController.php @@ -248,8 +248,10 @@ protected function insertHeaderOnIos(): void { /** * Set CSP options to allow the page be embedded using