Fix PHPStan issues

Author: emodric

bundle/Core/FieldType/Tags/FormMapper.php

@@ -68,13 +68,9 @@ public function mapFieldDefinitionForm(FormInterface $fieldDefinitionForm, Field
                     'property_path' => 'validatorConfiguration[TagsValueValidator][maxTags]',
                     'label' => 'field_definition.tags.validator.max_tags',
                     'constraints' => [
-                        new Constraints\Type(['type' => 'int']),
+                        new Constraints\Type(type: 'int'),
                         new Constraints\NotBlank(),
-                        new Constraints\GreaterThanOrEqual(
-                            [
-                                'value' => 0,
-                            ],
-                        ),
+                        new Constraints\PositiveOrZero(),
                     ],
                     'empty_data' => 0,
                     'attr' => [
@@ -90,7 +86,7 @@ public function mapFieldDefinitionForm(FormInterface $fieldDefinitionForm, Field
                     'property_path' => 'fieldSettings[hideRootTag]',
                     'label' => 'field_definition.tags.settings.hide_root_tag',
                     'constraints' => [
-                        new Constraints\Type(['type' => 'bool']),
+                        new Constraints\Type(type: 'bool'),
                         new Constraints\NotNull(),
                     ],
                 ],
@@ -104,13 +100,10 @@ public function mapFieldDefinitionForm(FormInterface $fieldDefinitionForm, Field
                     'property_path' => 'fieldSettings[editView]',
                     'label' => 'field_definition.tags.settings.edit_view',
                     'constraints' => [
-                        new Constraints\Type(['type' => 'string']),
+                        new Constraints\Type(type: 'string'),
                         new Constraints\NotBlank(),
                         new Constraints\Choice(
-                            [
-                                'choices' => array_values($editViewChoices),
-                                'strict' => true,
-                            ],
+                            choices: array_values($editViewChoices),
                         ),
                     ],
                 ],

bundle/DependencyInjection/Configuration.php

@@ -9,11 +9,12 @@
 
 final class Configuration extends SiteAccessConfiguration
 {
+    /**
+     * @return \Symfony\Component\Config\Definition\Builder\TreeBuilder<'array'>
+     */
     public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('netgen_tags');
-
-        /** @var \Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition $rootNode */
         $rootNode = $treeBuilder->getRootNode();
 
         $this->generateScopeBaseNode($rootNode)

bundle/Form/Type/TagTreeType.php

@@ -37,7 +37,7 @@ public function configureOptions(OptionsResolver $resolver): void
                     'allowRootTag' => true,
                     'disableSubtree' => [],
                     'constraints' => static fn (Options $options): array => [
-                        new Constraints\Type(['type' => 'int']),
+                        new Constraints\Type(type: 'int'),
                         new Constraints\NotBlank(),
                         new TagConstraint(['allowRootTag' => $options['allowRootTag']]),
                     ],

bundle/Validator/Structs/CreateStructValidator.php

@@ -19,31 +19,31 @@ public function validate(mixed $value, Constraint $constraint): void
         $validator->atPath('alwaysAvailable')->validate(
             $value->alwaysAvailable,
             [
-                new Constraints\Type(['type' => 'bool']),
+                new Constraints\Type(type: 'bool'),
                 new Constraints\NotNull(),
             ],
         );
 
         $validator->atPath('keyword')->validate(
             $value->getKeyword(),
             [
-                new Constraints\Type(['type' => 'string']),
+                new Constraints\Type(type: 'string'),
                 new Constraints\NotBlank(),
             ],
         );
 
         $validator->atPath('remoteId')->validate(
             $value->remoteId,
             [
-                new Constraints\Type(['type' => 'string']),
+                new Constraints\Type(type: 'string'),
                 new RemoteId(),
             ],
         );
 
         $validator->atPath('mainLanguageCode')->validate(
             $value->mainLanguageCode,
             [
-                new Constraints\Type(['type' => 'string']),
+                new Constraints\Type(type: 'string'),
                 new Constraints\NotBlank(),
                 new Language(),
             ],

bundle/Validator/Structs/SynonymCreateStructValidator.php

@@ -36,7 +36,7 @@ public function validate(mixed $value, Constraint $constraint): void
         $validator->atPath('mainTagId')->validate(
             $value->mainTagId,
             [
-                new Constraints\Type(['type' => 'int']),
+                new Constraints\Type(type: 'int'),
                 new Constraints\NotBlank(),
                 new Tag(['allowRootTag' => false]),
             ],

bundle/Validator/Structs/TagCreateStructValidator.php

@@ -36,7 +36,7 @@ public function validate(mixed $value, Constraint $constraint): void
         $validator->atPath('parentTagId')->validate(
             $value->parentTagId,
             [
-                new Constraints\Type(['type' => 'int']),
+                new Constraints\Type(type: 'int'),
                 new Constraints\NotBlank(),
                 new Tag(),
             ],

bundle/Validator/Structs/TagUpdateStructValidator.php

@@ -36,23 +36,23 @@ public function validate(mixed $value, Constraint $constraint): void
         $validator->atPath('alwaysAvailable')->validate(
             $value->alwaysAvailable,
             [
-                new Constraints\Type(['type' => 'bool']),
+                new Constraints\Type(type: 'bool'),
                 new Constraints\NotNull(),
             ],
         );
 
         $validator->atPath('keyword')->validate(
             $value->getKeyword($constraint->languageCode),
             [
-                new Constraints\Type(['type' => 'string']),
+                new Constraints\Type(type: 'string'),
                 new Constraints\NotBlank(),
             ],
         );
 
         $validator->atPath('remoteId')->validate(
             $value->remoteId,
             [
-                new Constraints\Type(['type' => 'string']),
+                new Constraints\Type(type: 'string'),
                 new Constraints\NotBlank(),
                 new RemoteId(
                     [
@@ -66,7 +66,7 @@ public function validate(mixed $value, Constraint $constraint): void
             $validator->atPath('mainLanguageCode')->validate(
                 $value->mainLanguageCode,
                 [
-                    new Constraints\Type(['type' => 'string']),
+                    new Constraints\Type(type: 'string'),
                     new Constraints\NotBlank(),
                     new Language(),
                 ],