From 0c4bae811883d4c2bf98c305fadf63dd28c9905d Mon Sep 17 00:00:00 2001 From: brentyi Date: Thu, 15 Jan 2026 03:58:37 -0800 Subject: [PATCH] Fix array prop update edge cases --- src/viser/_assignable_props_api.py | 2 +- src/viser/client/src/mesh/BasicMesh.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/viser/_assignable_props_api.py b/src/viser/_assignable_props_api.py index edb60dbe8..0b09d5cbc 100644 --- a/src/viser/_assignable_props_api.py +++ b/src/viser/_assignable_props_api.py @@ -111,7 +111,7 @@ def props_setattr(self, name: str, value: Any) -> None: hash(current_value) if current_value == value: return - except TypeError: + except (TypeError, ValueError): pass # Update the value based on type. diff --git a/src/viser/client/src/mesh/BasicMesh.tsx b/src/viser/client/src/mesh/BasicMesh.tsx index a27b9e60c..068bcfc04 100644 --- a/src/viser/client/src/mesh/BasicMesh.tsx +++ b/src/viser/client/src/mesh/BasicMesh.tsx @@ -56,7 +56,7 @@ export const BasicMesh = React.forwardRef< geometry.computeVertexNormals(); geometry.computeBoundingSphere(); return geometry; - }, [message.props.vertices.buffer, message.props.faces.buffer]); + }, [message.props.vertices, message.props.faces]); // Clean up geometry when it changes. React.useEffect(() => {