Skip to content

Add --timeout option to the CLI #139

@andersy005

Description

@andersy005

Currently, when parsing the log file for Jupyter server information we use a while loop with a naive condition

):
pattern = 'is running at:'
while condition:
try:
result = self.run_command(f'cat {self.log_file}', echo=False, hide='out')
if pattern in result.stdout:
condition = False

This loop can easily turn into an infinite loop when something goes wrong and the log file is not found or empty. We should probably add a timeout option to the RemoteRunner class plus the CLI to allow users to configure how long we should wait before exiting the while loop.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    🌳 Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions