-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Currently, when parsing the log file for Jupyter server information we use a while loop with a naive condition
jupyter-forward/jupyter_forward/core.py
Lines 209 to 215 in 917c142
| ): | |
| pattern = 'is running at:' | |
| while condition: | |
| try: | |
| result = self.run_command(f'cat {self.log_file}', echo=False, hide='out') | |
| if pattern in result.stdout: | |
| condition = False |
This loop can easily turn into an infinite loop when something goes wrong and the log file is not found or empty. We should probably add a timeout option to the RemoteRunner class plus the CLI to allow users to configure how long we should wait before exiting the while loop.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Type
Projects
Status
🌳 Todo