fix(network): enhance isValidPort method to check for number type

fix(tests): ensure emitter is disposed after each test and improve cleanup

Author: ahmadnasriya

src/domains/network/network-utils.ts

@@ -150,7 +150,7 @@ class NetworkUtils {
      * @since v1.0.0
      */
     isValidPort(port: unknown): boolean {
-        return numbersGuard.isInteger(port) && port >= 0 && port <= 65535;
+        return numbersGuard.isNumber(port) && numbersGuard.isInteger(port) && port >= 0 && port <= 65535;
     }
 }
 

src/tools/queues/docs.ts

@@ -50,13 +50,13 @@ export interface BaseQueueTask<T = any, K extends Record<string, any> = Record<s
      * Optional callback executed when the task's action resolves successfully.
      * Receives the resolved value from `action`.
      */
-    onResolve?: (result?: T, metadata?: DeepReadonly<K>) => any | Promise<any>;
+    onResolve?: (result: T, metadata?: DeepReadonly<K>) => any | Promise<any>;
 
     /**
      * Optional callback executed if the task's action rejects with an error.
      * Receives the error thrown by `action`.
      */
-    onReject?: (error?: Error) => any | Promise<any>;
+    onReject?: (error: Error) => any | Promise<any>;
 
     /** Optional callback executed when the task completes, regardless of success or failure. */
     onDone?: () => any | Promise<any>;

tests/atomix/tools/eventEmitter.test.ts

@@ -4,6 +4,7 @@ describe('EventEmitter', () => {
     let emitter: EventEmitter;
 
     beforeEach(() => {
+        if (emitter) { emitter.dispose() }
         emitter = new EventEmitter();
         emitter.maxHandlers = 100; // disable limit during most tests
         jest.useFakeTimers();
@@ -13,6 +14,10 @@ describe('EventEmitter', () => {
         jest.useRealTimers();
     });
 
+    afterAll(() => {
+        emitter.dispose();
+    });
+
     it('should register and call a normal handler', async () => {
         const fn = jest.fn();
         emitter.on('test', fn);
@@ -47,7 +52,7 @@ describe('EventEmitter', () => {
         });
 
         emitter.on('async', () => callOrder.push('B'));
-        
+
         await emitter.emit('async');
         await new Promise(res => setTimeout(res, 100));
         expect(callOrder).toEqual(['A', 'B']);