chore(core): Only encrypt partial oauth state (#23590)

Author: afitzek

packages/cli/src/controllers/oauth/__tests__/oauth1-credential.controller.test.ts

@@ -56,6 +56,7 @@ describe('OAuth1CredentialController', () => {
 				cid: '1',
 				origin: 'static-credential',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			}),
 		).toString('base64');
 
@@ -87,6 +88,7 @@ describe('OAuth1CredentialController', () => {
 				cid: '1',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.getCredential.mockResolvedValueOnce(mockResolvedCredential);
 			// @ts-ignore
@@ -130,6 +132,7 @@ describe('OAuth1CredentialController', () => {
 				credentialResolverId: 'resolver-id',
 				authorizationHeader: 'Bearer token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			const dynamicReq = mock<OAuthRequest.OAuth1Credential.Callback>({
@@ -174,6 +177,7 @@ describe('OAuth1CredentialController', () => {
 				origin: 'dynamic-credential' as const,
 				authorizationHeader: 'Bearer token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			const dynamicReq = mock<OAuthRequest.OAuth1Credential.Callback>({
@@ -211,6 +215,7 @@ describe('OAuth1CredentialController', () => {
 				origin: 'dynamic-credential' as const,
 				credentialResolverId: 'resolver-id',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			const dynamicReq = mock<OAuthRequest.OAuth1Credential.Callback>({
@@ -249,6 +254,7 @@ describe('OAuth1CredentialController', () => {
 				credentialResolverId: 'resolver-id',
 				authorizationHeader: 'Invalid token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			const dynamicReq = mock<OAuthRequest.OAuth1Credential.Callback>({
@@ -285,6 +291,7 @@ describe('OAuth1CredentialController', () => {
 				cid: '1',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const undefinedOriginState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			const undefinedOriginReq = mock<OAuthRequest.OAuth1Credential.Callback>({

packages/cli/src/controllers/oauth/__tests__/oauth2-credential.controller.test.ts

@@ -82,6 +82,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			}),
 		).toString('base64');
 
@@ -120,6 +121,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.resolveCredential.mockResolvedValueOnce([
 				mockResolvedCredential,
@@ -183,6 +185,7 @@ describe('OAuth2CredentialController', () => {
 				credentialResolverId: 'resolver-id',
 				authorizationHeader: 'Bearer token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			oauthService.resolveCredential.mockResolvedValueOnce([
@@ -246,6 +249,7 @@ describe('OAuth2CredentialController', () => {
 				origin: 'dynamic-credential' as const,
 				authorizationHeader: 'Bearer token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			oauthService.resolveCredential.mockResolvedValueOnce([
@@ -304,6 +308,7 @@ describe('OAuth2CredentialController', () => {
 				origin: 'dynamic-credential' as const,
 				credentialResolverId: 'resolver-id',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			oauthService.resolveCredential.mockResolvedValueOnce([
@@ -363,6 +368,7 @@ describe('OAuth2CredentialController', () => {
 				credentialResolverId: 'resolver-id',
 				authorizationHeader: 'Invalid token123',
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const dynamicState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			oauthService.resolveCredential.mockResolvedValueOnce([
@@ -420,6 +426,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			const undefinedOriginState = Buffer.from(JSON.stringify(mockState)).toString('base64');
 			oauthService.resolveCredential.mockResolvedValueOnce([
@@ -480,6 +487,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.resolveCredential.mockResolvedValueOnce([
 				mockResolvedCredential,
@@ -538,6 +546,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.resolveCredential.mockResolvedValueOnce([
 				mockResolvedCredential,
@@ -598,6 +607,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.resolveCredential.mockResolvedValueOnce([
 				mockResolvedCredential,
@@ -661,6 +671,7 @@ describe('OAuth2CredentialController', () => {
 				userId: '123',
 				origin: 'static-credential' as const,
 				createdAt: timestamp,
+				data: 'encrypted-data',
 			};
 			oauthService.resolveCredential.mockResolvedValueOnce([
 				mockResolvedCredential,