Merge pull request #12 from mtsmfm/ignore

Ignore invalid XML files

Author: mtsmfm

src/main.rs

@@ -88,8 +88,14 @@ fn get_test_file_results(junit_xml_report_dir: &PathBuf) -> Result<HashMap<PathB
     let mut test_file_results = HashMap::new();
 
     for xml_path in expand_globs(&vec![String::from(xml_glob)])? {
-        let reader = BufReader::new(File::open(xml_path)?);
-        let test_result_xml: TestResultXml = from_reader(reader)?;
+        let reader = BufReader::new(File::open(&xml_path)?);
+        let test_result_xml: TestResultXml = from_reader(reader).unwrap_or_else(|err| {
+            warn!("Failed to parse XML file {:?}: {}", xml_path, err);
+            TestResultXml {
+                test_suites: None,
+                test_cases: None,
+            }
+        });
 
         let test_suites = test_result_xml.test_suites.unwrap_or(vec![TestSuite {
             test_cases: test_result_xml.test_cases.unwrap_or(vec![]),

tests/fixtures/invalid/a_spec.rb

@@ -0,0 +1,2 @@
+/home/mtsmfm/ghq/github.com/mtsmfm/split-test/tests/fixtures/invalid/a_spec.rb
+/home/mtsmfm/ghq/github.com/mtsmfm/split-test/tests/fixtures/invalid/b_spec.rb

tests/fixtures/invalid/b_spec.rb

@@ -0,0 +1 @@
+foo

tests/fixtures/invalid/empty.xml

@@ -175,3 +175,68 @@ fn test_multiple_tests_glob_arg() -> Result<(), Box<dyn std::error::Error>> {
 
     Ok(())
 }
+
+#[test]
+fn test_invalid_report() -> Result<(), Box<dyn std::error::Error>> {
+    let mut cmd = Command::cargo_bin("split-test")?;
+
+    cmd.current_dir("tests/fixtures/invalid")
+        .arg("--junit-xml-report-dir")
+        .arg(".")
+        .arg("--node-index")
+        .arg("0")
+        .arg("--node-total")
+        .arg("2")
+        .arg("--tests-glob")
+        .arg("**/*_spec.rb")
+        .arg("--debug");
+
+    cmd.assert()
+        .success()
+        .stdout(predicate::str::contains("a_spec.rb"))
+        .stdout(predicate::str::contains("b_spec.rb").not())
+        .stderr(
+            predicate::str::is_match(
+                "Failed to parse XML file \".*/tests/fixtures/invalid/empty.xml\"",
+            )
+            .unwrap(),
+        )
+        .stderr(
+            predicate::str::is_match(
+                "Failed to parse XML file \".*/tests/fixtures/invalid/foo.xml\"",
+            )
+            .unwrap(),
+        );
+
+    cmd = Command::cargo_bin("split-test")?;
+
+    cmd.current_dir("tests/fixtures/invalid")
+        .arg("--junit-xml-report-dir")
+        .arg(".")
+        .arg("--node-index")
+        .arg("1")
+        .arg("--node-total")
+        .arg("2")
+        .arg("--tests-glob")
+        .arg("**/*_spec.rb")
+        .arg("--debug");
+
+    cmd.assert()
+        .success()
+        .stdout(predicate::str::contains("a_spec.rb").not())
+        .stdout(predicate::str::contains("b_spec.rb"))
+        .stderr(
+            predicate::str::is_match(
+                "Failed to parse XML file \".*/tests/fixtures/invalid/empty.xml\"",
+            )
+            .unwrap(),
+        )
+        .stderr(
+            predicate::str::is_match(
+                "Failed to parse XML file \".*/tests/fixtures/invalid/foo.xml\"",
+            )
+            .unwrap(),
+        );
+
+    Ok(())
+}