node: we need to fix the node-gyp path conversion

[Kreijstal]

Description / Steps to reproduce the issue

git clone https://github.com/Kreijstal/weak-napi.git
cd weak-napi
npm i node-addon-api # if you try npm i, you get the same, this is the fastest way to debug it.
node-gyp configure
node-gyp build # WILL FAIL
cat build/node_modules/node-addon-api/nothing.target.mk # see error

OBJS has some path nonsense absolute+relative

Expected behavior

well it doesnt mix absolute with relative paths.

Actual behavior

it does.

Verification

• I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-22631

MINGW environments affected

• MINGW64
• MINGW32
• UCRT64
• CLANG64
• CLANGARM64

Are you willing to submit a PR?

No response

[Kreijstal]

I finally did it, I fixed node-gyp bullshit.

workaround:

wget -O "$MINGW_PREFIX/lib/node_modules/npm/node_modules/node-gyp/addon.gypi" https://raw.githubusercontent.com/Kreijstal/node-gyp/refs/heads/beautiful/addon.gypi
wget -O "$MINGW_PREFIX/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py" https://raw.githubusercontent.com/Kreijstal/node-gyp/refs/heads/beautiful/gyp/pylib/gyp/generator/make.py

too lazy to submit a patch

it is not patch ready anyway but it works

[Kreijstal]

goddamn

topkek@win11 UCRT64 ~/git/ref-napi
# npm i
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated har-validator@5.1.5: this library is no longer supported
npm warn deprecated transformers@2.1.0: Deprecated, use jstransformer
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.1.3: Glob versions prior to v9 are no longer supported
npm warn deprecated constantinople@3.0.2: Please update to at least constantinople 3.1.1
npm warn deprecated debug@3.2.6: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm warn deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm warn deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated fstream@1.0.12: This package is no longer supported.
npm warn deprecated jade@1.11.0: Jade has been renamed to pug, please install the latest version of pug instead of jade

> ref-napi@3.0.3 install
> node-gyp-build

gyp info it worked if it ends with ok
gyp info using node-gyp@11.0.0
gyp info using node@23.5.0 | win32 | x64
gyp info find Python using Python version 3.12.9 found at "E:/msys64/ucrt64/bin/python3.exe"

gyp info spawn E:/msys64/ucrt64/bin/python3.exe
gyp info spawn args [
gyp info spawn args 'E:\\msys64\\ucrt64\\lib\\node_modules\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args 'E:\\msys64\\home\\topkek\\git\\ref-napi\\build\\config.gypi',
gyp info spawn args '-I',
gyp info spawn args 'E:\\msys64\\ucrt64\\lib\\node_modules\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args '-I',
gyp info spawn args 'E:\\msys64\\ucrt64\\include\\node\\common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=E:\\msys64\\ucrt64',
gyp info spawn args '-Dnode_gyp_dir=E:\\msys64\\ucrt64\\lib\\node_modules\\npm\\node_modules\\node-gyp',
gyp info spawn args '-Dnode_lib_file=E:\\msys64\\ucrt64\\lib\\libnode.dll.a',
gyp info spawn args '-Dmodule_root_dir=E:\\msys64\\home\\topkek\\git\\ref-napi',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/topkek/git/ref-napi/build'
  CXX(target) Release/obj.target/binding/src/binding.o
  CXX(target) Release/obj.target/binding/src/win_delay_load_hook.o
  CC(target) Release/obj.target/nothing/node_modules/node-addon-api/nothing.o
  CXX(target) Release/obj.target/nothing/src/win_delay_load_hook.o
  AR(target) Release/obj.target/node_modules/node-addon-api/nothing.a
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
  COPY Release/nothing.a
make: Leaving directory '/home/topkek/git/ref-napi/build'
gyp info ok 

added 506 packages, and audited 507 packages in 36s

93 packages are looking for funding
  run `npm fund` for details

18 vulnerabilities (2 low, 6 moderate, 3 high, 7 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

that feels AMAZING

[Kreijstal]

we can for example install this btsimonh/node-ffi-napi#4
if we do
npm install --target_platform=mingw

[Kreijstal]

we can for example install this btsimonh/node-ffi-napi#4 if we do npm install --target_platform=mingw

ok no need to do that anymore npm install should work but nodejs/node-gyp#3166 would need to get merged first

[ognevny]

@Kreijstal can you confirm that the issue is fixed with nodejs 24.6.0-1?

[Kreijstal]

hmm with the examples I tried it seemed to work but I cannot guarantee it works for all examples.. but yes I guess it works in my limited testing