Remove iso8601, switch to directly using chrono for our tests

Author: badboy

Cargo.lock

@@ -55,7 +55,6 @@ oslog = { version = "0.1.0", default-features = false, features = ["logger"] }
 [dev-dependencies]
 env_logger = { version = "0.10.0", default-features = false, features = ["humantime"] }
 tempfile = "3.8.0"
-iso8601 = "0.4"
 ctor = "0.2.2"
 criterion = "0.7.0"
 

glean-core/Cargo.toml

@@ -5,15 +5,12 @@
 // #[allow(dead_code)] is required on this module as a workaround for
 // https://github.com/rust-lang/rust/issues/46379
 #![allow(dead_code)]
-use chrono::Timelike;
 use glean_core::{Glean, PingType, Result};
 
 use std::fs::{read_dir, File};
 use std::io::{BufRead, BufReader};
 use std::path::Path;
 
-use chrono::offset::TimeZone;
-use iso8601::Date::YMD;
 use serde_json::Value as JsonValue;
 
 use ctor::ctor;
@@ -170,26 +167,6 @@ impl PingBuilder {
     }
 }
 
-/// Converts an iso8601::DateTime to a chrono::DateTime<FixedOffset>
-pub fn iso8601_to_chrono(datetime: &iso8601::DateTime) -> chrono::DateTime<chrono::FixedOffset> {
-    if let YMD { year, month, day } = datetime.date {
-        return chrono::FixedOffset::east_opt(datetime.time.tz_offset_hours * 3600)
-            .unwrap()
-            .with_ymd_and_hms(
-                year,
-                month,
-                day,
-                datetime.time.hour,
-                datetime.time.minute,
-                datetime.time.second,
-            )
-            .unwrap()
-            .with_nanosecond(datetime.time.millisecond * 1_000_000)
-            .unwrap();
-    };
-    panic!("Unsupported datetime format");
-}
-
 /// Gets a vector of the currently queued pings.
 ///
 /// # Arguments

glean-core/tests/common/mod.rs

@@ -41,10 +41,10 @@ fn ping_info_must_contain_a_nonempty_start_and_end_time() {
     let ping_info = ping.content["ping_info"].as_object().unwrap();
 
     let start_time_str = ping_info["start_time"].as_str().unwrap();
-    let start_time_date = iso8601_to_chrono(&iso8601::datetime(start_time_str).unwrap());
+    let start_time_date = chrono::DateTime::parse_from_rfc3339(start_time_str).unwrap();
 
     let end_time_str = ping_info["end_time"].as_str().unwrap();
-    let end_time_date = iso8601_to_chrono(&iso8601::datetime(end_time_str).unwrap());
+    let end_time_date = chrono::DateTime::parse_from_rfc3339(end_time_str).unwrap();
 
     assert!(start_time_date <= end_time_date);
 }

glean-core/tests/ping_maker.rs

@@ -1125,12 +1125,6 @@ No `unsafe` introduced or affected in:
 """
 aggregated-from = "https://chromium.googlesource.com/chromium/src/+/main/third_party/rust/chromium_crates_io/supply-chain/audits.toml?format=TEXT"
 
-[[audits.google.audits.iso8601]]
-who = "George Burgess IV <[email protected]>"
-criteria = "safe-to-run"
-version = "0.4.2"
-aggregated-from = "https://chromium.googlesource.com/chromiumos/third_party/rust_crates/+/refs/heads/main/cargo-vet/audits.toml?format=TEXT"
-
 [[audits.google.audits.itertools]]
 who = "ChromeOS"
 criteria = "safe-to-run"