Facebook Container's door-hanger does not respect the dark theme

[sbadau]

Facebook Container Version: 2.1.0

Affected platforms:

• Windows 10 x64
• MacOS 10.15
• Ubuntu 18.04

Steps to reproduce

1. Add Facebook Container 2.1.0 to Firefox
2. Go to the Addons Manager -> Themes
3. Enable the dark theme
4. Click on the "Facebook Container" toolbar icon and on the buttons that are near.

Actual behavior
The Facebook Container's door-hanger is white, even if the rest of the menus and panels are dark.

Expected behavior
The Facebook Container's door-hanger should adapt to the selected Firefox theme (dark in this case).

[maxxcrawford]

@e-pang This will require artwork changes. See the (rough) example:

If one image can work for both themes, that's preferred.

[maxxcrawford]

Note - @media (prefers-color-scheme: dark) works in this context.

[e-pang]

i'll update so that the white space around the image is transparent. Hoping to get around to this either later today or tomorrow.

[e-pang]

Updated the images here - these should work fine in both light and dark theme: https://drive.google.com/open?id=1xB7YyO4Gxay9H7VO87pHMvRU0_dH8QQk

[dannycolin]

Hey @maxxcrawford , I'd be interested to implement this. I already have a WIP patch based on the one I made for MAC. I only have one small question. Do you have a preference for where the option to set the theme should be?

https://imgur.com/eiY4MNV

[maxxcrawford]

@dannycolin Yes! Here's the zip of those images.

updated-images.zip

As far as "where to put the option", I have an active PR to add a prefernces panel (#721). Note that you will probably finish this feature before we finiish ours, so it may be blocked. Lets' chat about timing next week.

cc/ @groovecoder

[dannycolin]

@dannycolin Yes! Here's the zip of those images.

By any chance, is there an svg version for the png images?

As far as "where to put the option", I have an active PR to add a prefernces panel (#721). Note that you will probably finish this feature before we finiish ours, so it may be blocked. Lets' chat about timing next week.

Sure, you can also ping me on Matrix if you prefer.