fix(model-client): ReplicatedModelJSImpl was causing Not in a transaction exceptions

slisson · slisson · commit 4d4f114f3c8b · 2026-01-28T18:24:54.000+01:00
This bug was introduced in 17.0.0
diff --git a/model-client/src/jsMain/kotlin/org/modelix/model/client2/MutableModelTreeJsImpl.kt b/model-client/src/jsMain/kotlin/org/modelix/model/client2/MutableModelTreeJsImpl.kt
@@ -39,12 +39,12 @@ internal class MutableModelTreeJsImpl(
     override val rootNode: INodeJS get() = getRootNodes().single()
 
     override fun getRootNodes(): Array<INodeJS> {
-        return model.getRootNodes().map { it.toJS() }.toTypedArray()
+        return model.executeRead { model.getRootNodes().map { it.toJS() }.toTypedArray() }
     }
 
     override fun resolveNode(reference: INodeReferenceJS): INodeJS? {
         val referenceObject = NodeReference(reference as String)
-        return model.tryResolveNode(referenceObject)?.toJS()
+        return model.executeRead { model.tryResolveNode(referenceObject)?.toJS() }
     }
 
     override fun addListener(handler: ChangeHandler) {

Original file line number	Diff line number	Diff line change
`@@ -39,12 +39,12 @@ internal class MutableModelTreeJsImpl(`
`39`	`39`	`override val rootNode: INodeJS get() = getRootNodes().single()`
`40`	`40`
`41`	`41`	`override fun getRootNodes(): Array<INodeJS> {`
`42`		`- return model.getRootNodes().map { it.toJS() }.toTypedArray()`
	`42`	`+ return model.executeRead { model.getRootNodes().map { it.toJS() }.toTypedArray() }`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`override fun resolveNode(reference: INodeReferenceJS): INodeJS? {`
`46`	`46`	`val referenceObject = NodeReference(reference as String)`
`47`		`- return model.tryResolveNode(referenceObject)?.toJS()`
	`47`	`+ return model.executeRead { model.tryResolveNode(referenceObject)?.toJS() }`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`override fun addListener(handler: ChangeHandler) {`